Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix]Add logs to track sequence of events for table creation #11946

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

aishikbh
Copy link
Contributor

@aishikbh aishikbh commented Nov 3, 2023

There are not enough logs for sub steps during table creation. Added logs to track the sequence of events to help debug issues in the future.

@aishikbh aishikbh marked this pull request as ready for review November 3, 2023 06:28
@aishikbh aishikbh changed the title [bugfix]Added logs to track sequence of events for table creation [bugfix]Add logs to track sequence of events for table creation Nov 3, 2023
Copy link
Contributor

@snleee snleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Merging #11946 (f16824a) into master (18639b9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #11946      +/-   ##
============================================
+ Coverage     61.42%   61.44%   +0.01%     
  Complexity     1147     1147              
============================================
  Files          2378     2378              
  Lines        128894   128900       +6     
  Branches      19929    19929              
============================================
+ Hits          79177    79203      +26     
+ Misses        44001    43984      -17     
+ Partials       5716     5713       -3     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.39% <100.00%> (+0.02%) ⬆️
java-21 61.28% <100.00%> (-0.02%) ⬇️
skip-bytebuffers-false 61.42% <100.00%> (+0.01%) ⬆️
skip-bytebuffers-true 61.26% <100.00%> (-0.01%) ⬇️
temurin 61.44% <100.00%> (+0.01%) ⬆️
unittests 61.44% <100.00%> (+0.01%) ⬆️
unittests1 46.64% <ø> (+0.01%) ⬆️
unittests2 27.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ntroller/helix/core/PinotHelixResourceManager.java 63.64% <100.00%> (+0.11%) ⬆️

... and 11 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@snleee snleee merged commit 6638d4e into apache:master Nov 6, 2023
19 checks passed
@aishikbh aishikbh deleted the addLogsToAddTable branch November 6, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants