Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early release AcquireReleaseColumnsSegmentOperator during explain plan #11945

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

saurabhd336
Copy link
Contributor

During explain plan query execution, once all the child operators of the AcquireReleaseColumnsSegmentOperator have been processed, we may call release() early and not defer until all segments are processed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Merging #11945 (965e3cf) into master (53e8033) will increase coverage by 0.11%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #11945      +/-   ##
============================================
+ Coverage     61.30%   61.41%   +0.11%     
- Complexity     1140     1146       +6     
============================================
  Files          2378     2378              
  Lines        128865   128869       +4     
  Branches      19927    19927              
============================================
+ Hits          78998    79144     +146     
+ Misses        44147    44004     -143     
- Partials       5720     5721       +1     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (?)
java-11 61.37% <100.00%> (+61.37%) ⬆️
java-21 61.28% <100.00%> (-0.03%) ⬇️
skip-bytebuffers-false 61.39% <100.00%> (+0.11%) ⬆️
skip-bytebuffers-true 61.26% <100.00%> (-0.01%) ⬇️
temurin 61.41% <100.00%> (+0.11%) ⬆️
unittests 61.40% <100.00%> (+0.11%) ⬆️
unittests1 46.60% <100.00%> (+0.14%) ⬆️
unittests2 27.65% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...in/java/org/apache/pinot/core/common/Operator.java 82.35% <100.00%> (+2.35%) ⬆️
...operator/AcquireReleaseColumnsSegmentOperator.java 75.00% <100.00%> (+11.36%) ⬆️

... and 18 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@saurabhd336 saurabhd336 merged commit 18639b9 into apache:master Nov 3, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants