Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] avoid npe when checking mirror server set assignment #11915

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

walterddr
Copy link
Contributor

@walterddr walterddr commented Oct 31, 2023

fix NPE introduce in #11578 (review)

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #11915 (7c62044) into master (abad6c8) will decrease coverage by 0.03%.
Report is 3 commits behind head on master.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master   #11915      +/-   ##
============================================
- Coverage     61.50%   61.47%   -0.03%     
  Complexity     1147     1147              
============================================
  Files          2378     2378              
  Lines        128844   128851       +7     
  Branches      19925    19926       +1     
============================================
- Hits          79242    79209      -33     
- Misses        43858    43924      +66     
+ Partials       5744     5718      -26     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 34.73% <33.33%> (-26.71%) ⬇️
java-21 61.34% <33.33%> (+0.02%) ⬆️
skip-bytebuffers-false 61.44% <33.33%> (-0.04%) ⬇️
skip-bytebuffers-true 61.28% <33.33%> (+0.01%) ⬆️
temurin 61.47% <33.33%> (-0.03%) ⬇️
unittests 61.46% <33.33%> (-0.03%) ⬇️
unittests1 46.65% <33.33%> (+0.03%) ⬆️
unittests2 27.68% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ery/planner/physical/MailboxAssignmentVisitor.java 85.18% <100.00%> (ø)
...mmon/assignment/InstanceAssignmentConfigUtils.java 0.00% <0.00%> (ø)

... and 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr merged commit 8d49b11 into apache:master Oct 31, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants