Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Agg literal attach should happen after BASIC_RULES #11863

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

walterddr
Copy link
Contributor

this fixes #11862

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for this

@Jackie-Jiang Jackie-Jiang added bugfix multi-stage Related to the multi-stage query engine labels Oct 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #11863 (871d6dd) into master (0174c71) will decrease coverage by 0.17%.
Report is 44 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #11863      +/-   ##
============================================
- Coverage     62.99%   62.83%   -0.17%     
  Complexity     1140     1140              
============================================
  Files          2343     2367      +24     
  Lines        126305   127943    +1638     
  Branches      19419    19744     +325     
============================================
+ Hits          79563    80388     +825     
- Misses        41071    41826     +755     
- Partials       5671     5729      +58     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (?)
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 14.42% <0.00%> (+0.01%) ⬆️
java-17 ?
java-20 ?
java-21 62.82% <100.00%> (?)
skip-bytebuffers-false 62.79% <100.00%> (?)
skip-bytebuffers-true 62.80% <100.00%> (?)
temurin 62.83% <100.00%> (-0.17%) ⬇️
unittests 62.82% <100.00%> (-0.17%) ⬇️
unittests1 66.83% <100.00%> (-0.27%) ⬇️
unittests2 14.42% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../java/org/apache/pinot/query/QueryEnvironment.java 90.59% <100.00%> (ø)

... and 149 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr merged commit 0dd7e8a into apache:master Oct 24, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[multistage][bug] literal attachment not working properly with other expansion rules
3 participants