-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Randomize integration tests port assignments #11861
Randomize integration tests port assignments #11861
Conversation
6ab9988
to
7e74808
Compare
Codecov Report
@@ Coverage Diff @@
## master #11861 +/- ##
============================================
- Coverage 61.45% 61.42% -0.04%
+ Complexity 1147 207 -940
============================================
Files 2375 2375
Lines 128500 128500
Branches 19846 19846
============================================
- Hits 78974 78934 -40
- Misses 43815 43864 +49
+ Partials 5711 5702 -9
Flags with carried forward coverage won't be shown. Click here to find out more. see 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
48ee629
to
d29b2ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. few questions
...tests/src/test/java/org/apache/pinot/integration/tests/GrpcBrokerClusterIntegrationTest.java
Show resolved
Hide resolved
pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java
Outdated
Show resolved
Hide resolved
d29b2ab
to
fa78876
Compare
324893c
to
a900fd7
Compare
a900fd7
to
f4a11fd
Compare
f4a11fd
to
b7d2877
Compare
Randomize pinot component ports to avoid port already bind issue