Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize integration tests port assignments #11861

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Oct 23, 2023

Randomize pinot component ports to avoid port already bind issue

@xiangfu0 xiangfu0 force-pushed the random-integration-test-ports branch 2 times, most recently from 6ab9988 to 7e74808 Compare October 23, 2023 22:55
@xiangfu0 xiangfu0 changed the title Radomize server port to avoid port already bind issue Randomize integration tests port assignments Oct 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #11861 (b7d2877) into master (5d58102) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11861      +/-   ##
============================================
- Coverage     61.45%   61.42%   -0.04%     
+ Complexity     1147      207     -940     
============================================
  Files          2375     2375              
  Lines        128500   128500              
  Branches      19846    19846              
============================================
- Hits          78974    78934      -40     
- Misses        43815    43864      +49     
+ Partials       5711     5702       -9     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (ø)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 61.39% <ø> (-0.02%) ⬇️
java-21 61.30% <ø> (-0.01%) ⬇️
skip-bytebuffers-false 61.41% <ø> (-0.01%) ⬇️
skip-bytebuffers-true 61.28% <ø> (-0.01%) ⬇️
temurin 61.42% <ø> (-0.04%) ⬇️
unittests 61.42% <ø> (-0.04%) ⬇️
unittests1 46.65% <ø> (+<0.01%) ⬆️
unittests2 27.57% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 force-pushed the random-integration-test-ports branch 5 times, most recently from 48ee629 to d29b2ab Compare October 24, 2023 22:02
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. few questions

@xiangfu0 xiangfu0 force-pushed the random-integration-test-ports branch from f4a11fd to b7d2877 Compare October 27, 2023 06:03
@xiangfu0 xiangfu0 merged commit ce25936 into apache:master Oct 27, 2023
19 checks passed
@xiangfu0 xiangfu0 deleted the random-integration-test-ports branch October 27, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants