Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log query and emit metrics for grpc request and multi-stage leaf stage #11838

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

Jackie-Jiang
Copy link
Contributor

  • Separate server query log and metric emitting into a separate class: ServerQueryLogger
  • Allow logging query and emitting metric for GRPC request and multi-stage leaf stage
  • Bugfixes:
    • Add numResizes into prometheus config
    • Change resizeTimeMs to be a meter instead of gauge
  • Configuration change:
    • pinot.server.query.log.maxRatePerSecond to replace the deprecated pinot.query.scheduler.query.log.maxRatePerSecond (backward compatible)
    • pinot.server.query.log.droppedReportMaxRatePerSecond to configure the dropped log report frequency

Release Notes

New config added for server:

  • pinot.server.query.log.maxRatePerSecond: query log max rate (QPS, default 10K)
  • pinot.server.query.log.droppedReportMaxRatePerSecond: dropped query log report max rate (QPS, default 1)

@Jackie-Jiang Jackie-Jiang added enhancement release-notes Referenced by PRs that need attention when compiling the next release notes Configuration Config changes (addition/deletion/change in behavior) bugfix refactor observability multi-stage Related to the multi-stage query engine labels Oct 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #11838 (4b05e5a) into master (86d3c44) will decrease coverage by 0.08%.
Report is 3 commits behind head on master.
The diff coverage is 9.60%.

@@             Coverage Diff              @@
##             master   #11838      +/-   ##
============================================
- Coverage     66.35%   66.28%   -0.08%     
  Complexity      207      207              
============================================
  Files          2350     2351       +1     
  Lines        127281   127310      +29     
  Branches      19603    19606       +3     
============================================
- Hits          84463    84383      -80     
- Misses        36924    37037     +113     
+ Partials       5894     5890       -4     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 66.25% <9.60%> (-0.08%) ⬇️
java-21 49.82% <6.40%> (-16.41%) ⬇️
skip-bytebuffers-false 66.26% <9.60%> (-0.09%) ⬇️
skip-bytebuffers-true 49.80% <6.40%> (+31.99%) ⬆️
temurin 66.28% <9.60%> (-0.08%) ⬇️
unittests 66.28% <9.60%> (-0.08%) ⬇️
unittests1 67.05% <6.66%> (-0.07%) ⬇️
unittests2 17.80% <3.20%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/org/apache/pinot/common/metrics/ServerGauge.java 92.85% <ø> (-0.17%) ⬇️
...a/org/apache/pinot/common/metrics/ServerMeter.java 97.70% <100.00%> (+0.02%) ⬆️
...rg/apache/pinot/server/starter/ServerInstance.java 84.02% <100.00%> (+0.11%) ⬆️
...va/org/apache/pinot/spi/utils/CommonConstants.java 28.00% <ø> (ø)
.../java/org/apache/pinot/server/conf/ServerConf.java 93.10% <75.00%> (-2.90%) ⬇️
...che/pinot/core/query/scheduler/QueryScheduler.java 62.50% <50.00%> (-3.96%) ⬇️
...che/pinot/core/transport/grpc/GrpcQueryServer.java 0.00% <0.00%> (ø)
...e/operator/LeafStageTransferableBlockOperator.java 85.00% <20.00%> (-1.29%) ⬇️
...che/pinot/core/query/logger/ServerQueryLogger.java 2.85% <2.85%> (ø)

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit 996f060 into apache:master Oct 21, 2023
21 checks passed
@Jackie-Jiang Jackie-Jiang deleted the grpc_query_log branch October 21, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Configuration Config changes (addition/deletion/change in behavior) enhancement multi-stage Related to the multi-stage query engine observability refactor release-notes Referenced by PRs that need attention when compiling the next release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants