Fix a null related error in queries like: #11829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gortiz
force-pushed
the
fix-order-not-sorted-null-values
branch
2 times, most recently
from
6c6baf5
to
9374b7d
Compare
gortiz
commented
Oct 18, 2023
| queryContext.setNullHandlingEnabled(true); | ||
| List<Object[]> rows = executeQuery(queryContext); | ||
| assertNull(rows.get(0)[0], "Column 'col1' value should be 'null' when null handling is enabled"); | ||
| assertNull(rows.get(0)[1], "Column 'col2' value should be 'null' when null handling is enabled"); |
There was a problem hiding this comment.
Without this path, this line failed with:
java.lang.AssertionError: Column 'col2' value should be 'null' when null handling is enabled
Expected :null
Actual :-2147483648
``` select salary from mytable where salary is null order by description option(enableNullHandling=true) ``` Which didn't return null values for not ordered columns
gortiz
force-pushed
the
fix-order-not-sorted-null-values
branch
from
9374b7d
to
c1cda08
Compare
Codecov Report
@@ Coverage Diff @@
## master #11829 +/- ##
=========================================
Coverage 66.48% 66.49%
Complexity 207 207
=========================================
Files 2343 2343
Lines 126418 126428 +10
Branches 19440 19445 +5
=========================================
+ Hits 84054 84064 +10
Misses 36499 36499
Partials 5865 5865
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have detected that queries like
were incorrectly executed. Specifically, the problem was that null bitmap was not applied on projected columns that were not in the order by expression in
SelectionOrderByOperator.computePartiallyOrdered.In the previous example, for each null value in
col2, Pinot returns the default null value for that column instead ofnull. This patch fixes that and adds some regression tests.