Fix a flaky test #11771
Merged
Fix a flaky test #11771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
39
to
40
| Set<Integer> expectedResult = new LinkedHashSet(); | ||
| expectedResult.addAll(Arrays.asList(0, 1, 4, 5, 6, 7, 8, 9, 11, 12, 13, 14, 19, 20, 25, 27, 29)); |
There was a problem hiding this comment.
Suggested change
| Set<Integer> expectedResult = new LinkedHashSet(); | |
| expectedResult.addAll(Arrays.asList(0, 1, 4, 5, 6, 7, 8, 9, 11, 12, 13, 14, 19, 20, 25, 27, 29)); | |
| List<Integer> expectedResult = Arrays.asList(0, 1, 4, 5, 6, 7, 8, 9, 11, 12, 13, 14, 19, 20, 25, 27, 29); |
There was a problem hiding this comment.
Thanks for the prompt reply! I have changed the patch based on the suggestion.
|
Please fix the import |
Codecov Report
@@ Coverage Diff @@
## master #11771 +/- ##
============================================
- Coverage 63.13% 62.98% -0.16%
Complexity 1117 1117
============================================
Files 2342 2342
Lines 125916 125996 +80
Branches 19370 19378 +8
============================================
- Hits 79501 79362 -139
- Misses 40749 40968 +219
Partials 5666 5666
Flags with carried forward coverage won't be shown. Click here to find out more. see 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix a flaky test
org.apache.pinot.core.operator.filter.NotFilterOperatorTest#testNotOperatorin modulepinot-core.Test failures
Root cause and fix
In line 38,
expectedResultis defined as aHashSet, which does not guarantee the orders of its elements, so in line 46, when iterating the elements of aHashSet, the elements returned are not in a consistent order, which leads to test failures. To fix the flakiness, useLinkedHashSetinstead ofHashSet.