[test]more geospatial v2 integration tests #11741
Conversation
xiangfu0
changed the title
Codecov Report
@@ Coverage Diff @@
## master #11741 +/- ##
============================================
+ Coverage 63.09% 63.13% +0.04%
Complexity 1117 1117
============================================
Files 2342 2342
Lines 125900 125900
Branches 19362 19362
============================================
+ Hits 79437 79490 +53
+ Misses 40817 40759 -58
- Partials 5646 5651 +5
Flags with carried forward coverage won't be shown. Click here to find out more. see 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -309,7 +309,9 @@ public void testStPointFunctionWithV2(boolean useMultiStageQueryEngine) | |||
| + "b.st_point, " | |||
| + "b.st_point_1, " | |||
| + "ST_DISTANCE(ST_Point(a.st_x, a.st_y, -1), b.st_point), " | |||
There was a problem hiding this comment.
Not introduced in this PR, but this should be 0 instead of -1. -1 is not a valid representation of boolean
There was a problem hiding this comment.
I was checking the Boolean utils, any value other than 1 is treated as false, hence the test.
There was a problem hiding this comment.
That is due to the current implementation. In SQL standard, any number other than 0 is treated as true. #11763 fixes this behavior
intermediate stage with literal