Fix StPoint scalar function usage in multi-stage engine intermediate stage

[xiangfu0]

Current stPoint only supports boolean as 3rd argument, this is not aligned with Transformer function which can be either INT or BOOLEAN.

1. Make Scalar function signature for stPoint to use Object as 3rd argument
2. Update StPoint registration in TransformFunctionType
3. Support both BYTES and STRING in H3IndexFilterOperator to handle binary literal values.
4. Add test for v2 intermediate stage in org.apache.pinot.integration.tests.custom.GeoSpatialTest

[codecov-commenter]

Codecov Report

Merging #11731 (e7481da) into master (78fc66b) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 63.63%.

@@             Coverage Diff              @@
##             master   #11731      +/-   ##
============================================
- Coverage     63.12%   63.10%   -0.02%     
  Complexity     1118     1118              
============================================
  Files          2342     2342              
  Lines        125889   125924      +35     
  Branches      19360    19364       +4     
============================================
+ Hits          79462    79469       +7     
- Misses        40783    40799      +16     
- Partials       5644     5656      +12     

Flag	Coverage Δ
integration	<0.01% <0.00%> (ø)
integration1	<0.01% <0.00%> (ø)
integration2	0.00% <0.00%> (ø)
java-11	50.13% <63.63%> (-12.93%)	⬇️
java-17	62.95% <63.63%> (-0.03%)	⬇️
java-20	62.95% <63.63%> (-0.01%)	⬇️
temurin	63.10% <63.63%> (-0.02%)	⬇️
unittests	63.10% <63.63%> (-0.02%)	⬇️
unittests1	67.25% <63.63%> (-0.04%)	⬇️
unittests2	14.43% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...e/pinot/common/function/TransformFunctionType.java	89.32% <100.00%> (ø)
...geospatial/transform/function/StPointFunction.java	100.00% <100.00%> (ø)
...geospatial/transform/function/ScalarFunctions.java	82.75% <0.00%> (-3.45%)	⬇️
...ot/core/operator/filter/H3IndexFilterOperator.java	82.65% <40.00%> (-0.69%)	⬇️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[walterddr]

Suggested change

	OperandTypes.family(ImmutableList.of(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC, SqlTypeFamily.ANY),
	OperandTypes.or(
	OperandTypes.family(ImmutableList.of(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC)),
	OperandTypes.family(ImmutableList.of(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC, SqlTypeFamily.BOOLEAN))
	),

[xiangfu0]

somehow this doesn't honor ordinal -> ordinal > 1 && ordinal < 4 to handle variable number of parameters.

[xiangfu0]

When I try to define this as:

  ST_POINT("ST_Point", ReturnTypes.explicit(SqlTypeName.VARBINARY),
      OperandTypes.or(
          OperandTypes.family(ImmutableList.of(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC),
              ordinal -> ordinal > 1 && ordinal < 4),
          OperandTypes.family(ImmutableList.of(SqlTypeFamily.NUMERIC, SqlTypeFamily.NUMERIC, SqlTypeFamily.BOOLEAN),
              ordinal -> ordinal > 1 && ordinal < 4)),
      "stPoint"),

The StPoint(1,2) will fail.

[walterddr]

ah. i see. that's fine for now

[yupeng9]

what if isGeography is not given boolean up?

[walterddr]

BooleanUtils.toBoolean actually works for number/string/boolean type.

[yupeng9]

I see. for non-boolean value, will it handle exception?

[xiangfu0]

this is our internal boolean util, it can handle number/string/boolean

public static boolean toBoolean(Object booleanObject) {
    if (booleanObject == null) {
      return false;
    } else if (booleanObject instanceof String) {
      return BooleanUtils.toBoolean((String) booleanObject);
    } else if (booleanObject instanceof Number) {
      return ((Number) booleanObject).intValue() == INTERNAL_TRUE;
    } else if (booleanObject instanceof Boolean) {
      return (boolean) booleanObject;
    } else {
      throw new IllegalArgumentException("Illegal type for boolean conversion: " + booleanObject.getClass());
    }
  }

[walterddr]

lgtm we should add more tests for other ST later