Reduce cpu usage by avoiding throwing an exception during query execution #11715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11715 +/- ##
============================================
- Coverage 63.05% 62.97% -0.08%
+ Complexity 1118 1117 -1
============================================
Files 2342 2342
Lines 125787 125881 +94
Branches 19335 19357 +22
============================================
- Hits 79314 79273 -41
- Misses 40813 40948 +135
Partials 5660 5660
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 67 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java
Show resolved
Hide resolved
vvivekiyer
force-pushed
the
easy_perf_win_exception
branch
from
3861e3b
to
eba7868
Compare
Jackie-Jiang
approved these changes
Oct 2, 2023
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Xiaotian (Jackie) Jiang <17555551+Jackie-Jiang@users.noreply.github.com>
siddharthteotia
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9092, we added query execution stats to fetch setNumConsumingSegmentsProcessed and setNumConsumingSegmentsMatched
In one of our production clusters, we observed that
Operator.getIndexSegment -> UnsupportedOperationException()was consuming > 8% of CPU. Analyzing it, the RCA is as follows:The process of throwing an exception (needlessly in this case) is expensive CPU-wise because it collects a stack-trace (which is expensive and slow) amongst other things. Some benchmarking here.
Attaching flamegraph that shows CPU usage
cc: @dinoocch @siddharthteotia