Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a metric to measure total thread cpu time for a table #11713

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

mcvsubbu
Copy link
Contributor

Allows us to compute the total thread cpu time each table uses for queries.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #11713 (0fd4f92) into master (b7cda01) will decrease coverage by 0.09%.
Report is 27 commits behind head on master.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master   #11713      +/-   ##
============================================
- Coverage     63.12%   63.04%   -0.09%     
+ Complexity     1121     1117       -4     
============================================
  Files          2343     2342       -1     
  Lines        125665   125790     +125     
  Branches      19312    19335      +23     
============================================
- Hits          79324    79299      -25     
- Misses        40681    40834     +153     
+ Partials       5660     5657       -3     
Flag Coverage Δ
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 63.01% <50.00%> (-0.04%) ⬇️
java-17 62.92% <50.00%> (-0.04%) ⬇️
java-20 14.43% <0.00%> (-48.51%) ⬇️
temurin 63.04% <50.00%> (-0.09%) ⬇️
unittests 63.03% <50.00%> (-0.09%) ⬇️
unittests1 67.18% <50.00%> (-0.05%) ⬇️
unittests2 14.43% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/org/apache/pinot/common/metrics/ServerMeter.java 97.64% <100.00%> (+0.02%) ⬆️
...che/pinot/core/query/scheduler/QueryScheduler.java 70.46% <0.00%> (-0.96%) ⬇️

... and 58 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jasperjiaguo jasperjiaguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackjlli jackjlli merged commit 5308cf0 into apache:master Oct 2, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants