Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add float type into literal thrift #11697

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

Jackie-Jiang
Copy link
Contributor

We need to preserve the type of the literal to distinguish float and double.
This solved #6814

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #11697 (c72c098) into master (ce017c0) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11697      +/-   ##
============================================
- Coverage     63.06%   63.05%   -0.02%     
+ Complexity     1120     1117       -3     
============================================
  Files          2343     2342       -1     
  Lines        125676   125667       -9     
  Branches      19318    19319       +1     
============================================
- Hits          79258    79234      -24     
- Misses        40770    40772       +2     
- Partials       5648     5661      +13     
Flag Coverage Δ
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.01% <ø> (-0.03%) ⬇️
java-17 14.45% <ø> (-48.45%) ⬇️
java-20 14.45% <ø> (-48.46%) ⬇️
temurin 63.05% <ø> (-0.02%) ⬇️
unittests 63.04% <ø> (-0.02%) ⬇️
unittests1 67.17% <ø> (-0.05%) ⬇️
unittests2 14.47% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit 572d56d into apache:master Sep 27, 2023
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the float_literal branch September 27, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants