[multistage] default enable dynamic broadcast for SEMI #11696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11696 +/- ##
============================================
- Coverage 63.10% 63.05% -0.05%
- Complexity 1120 1121 +1
============================================
Files 2343 2343
Lines 125672 125672
Branches 19317 19317
============================================
- Hits 79309 79248 -61
- Misses 40705 40773 +68
+ Partials 5658 5651 -7
Flags with carried forward coverage won't be shown. Click here to find out more. see 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| JoinInfo joinInfo = join.analyzeCondition(); | ||
| RelNode left = join.getLeft() instanceof HepRelVertex ? ((HepRelVertex) join.getLeft()).getCurrentRel() | ||
| : join.getLeft(); | ||
| RelNode right = join.getRight() instanceof HepRelVertex ? ((HepRelVertex) join.getRight()).getCurrentRel() | ||
| : join.getRight(); | ||
| return left instanceof Exchange && right instanceof Exchange | ||
| && PinotRuleUtils.noExchangeInSubtree(left.getInput(0)) | ||
| && (join.getJoinType() == JoinRelType.SEMI && joinInfo.nonEquiConditions.isEmpty()); | ||
| // default enable dynamic broadcast for SEMI join unless other join strategy were specified | ||
| && (!explicitOtherStrategy && join.getJoinType() == JoinRelType.SEMI && joinInfo.nonEquiConditions.isEmpty()); |
There was a problem hiding this comment.
Is dynamic broadcast useful for non-SEMI join? Currently it won't be applied even if we explicitly hint about it
There was a problem hiding this comment.
it can be in the future. currently it will only apply to SEMI join
Jackie-Jiang
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's no reason not to enable dynamic broadcast for SEMI joins at the current status of multi-stage,
except for the situation where the right table is so large and the left table is not partitioned. in which case we have a fallback option to enable hash table join
joinOptions(join_strategy = 'hash_table')