Cleanup some reader/writer logic for raw forward index #11669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
commented
Sep 25, 2023
There was a problem hiding this comment.
@saurabhd336 We want to handle the above 2 TODOs (add raw index reader for V4 multi-value index)
| } | ||
| } else { | ||
| // TODO: Support V4 MV reader |
| 1); | ||
| _indexWriter = new VarByteChunkSVForwardIndexWriter(file, compressionType, totalDocs, numDocsPerChunk, | ||
| totalMaxLength, writerVersion); | ||
| // TODO: Support V4 MV reader |
Codecov Report
@@ Coverage Diff @@
## master #11669 +/- ##
============================================
- Coverage 63.10% 63.07% -0.03%
+ Complexity 1121 1120 -1
============================================
Files 2343 2343
Lines 125693 125665 -28
Branches 19310 19312 +2
============================================
- Hits 79315 79262 -53
- Misses 40728 40752 +24
- Partials 5650 5651 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
force-pushed
the
cleanup_raw_index
branch
from
f7f9bae
to
81b77c9
Compare
xiangfu0
reviewed
Sep 25, 2023
| return dataType.getStoredType() == DataType.STRING | ||
| private static String getValidPropertyValue(String value, boolean isMax, DataType storedType) { | ||
| String valueWithinLengthLimit = getValueWithinLengthLimit(value, isMax, storedType); | ||
| return storedType.getStoredType() == DataType.STRING |
There was a problem hiding this comment.
storedType == DataType.STRING?
Jackie-Jiang
force-pushed
the
cleanup_raw_index
branch
from
81b77c9
to
4ed3862
Compare
xiangfu0
approved these changes
Sep 25, 2023
| totalMaxLength, writerVersion); | ||
| // TODO: Support V4 MV reader | ||
| // Currently fall back to V2 for backward compatible | ||
| if (writerVersion >= VarByteChunkForwardIndexWriterV4.VERSION) { |
There was a problem hiding this comment.
just use writerVersion == VarByteChunkForwardIndexWriterV4.VERSION to be explicit?
| } | ||
| } | ||
| } | ||
| SegmentColumnarIndexCreator.addColumnMinMaxValueInfo(_segmentProperties, columnName, String.valueOf(min), |
There was a problem hiding this comment.
This is common and can be moved out of switch case statement?
There was a problem hiding this comment.
This cannot be moved because min and max has different type for different data type
Jackie-Jiang
force-pushed
the
cleanup_raw_index
branch
from
4ed3862
to
1f60a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the preparation for complete V4 support