Update the table config in quick start #11652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11652 +/- ##
============================================
- Coverage 63.13% 63.09% -0.05%
+ Complexity 1121 1120 -1
============================================
Files 2335 2335
Lines 125216 125216
Branches 19209 19209
============================================
- Hits 79054 79003 -51
- Misses 40526 40580 +54
+ Partials 5636 5633 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
approved these changes
Sep 21, 2023
| "realtime.segment.flush.threshold.time": "12h", | ||
| "realtime.segment.flush.threshold.size": "100000" | ||
| } | ||
| ] |
There was a problem hiding this comment.
any reason why the kafka version doesn't have the derived transformConfigs columns?
either make the consistent or keep a "json" name in the filename like the upsert side table config?
There was a problem hiding this comment.
Good catch. I think I made the wrong copy paste
Jackie-Jiang
force-pushed
the
quick_start_table_config
branch
from
31caa0f
to
df58257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better reflect the correct usage of each config