Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Request class from pinot-java-client #11614

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

lucifer4j
Copy link
Contributor

also delete related methods.

partially fix: #11582

also delete related methods.

partially fix: apache#11582
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #11614 (0b19657) into master (4292356) will increase coverage by 0.24%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11614      +/-   ##
============================================
+ Coverage     62.92%   63.16%   +0.24%     
- Complexity     1103     1107       +4     
============================================
  Files          2326     2323       -3     
  Lines        124984   124514     -470     
  Branches      19080    18994      -86     
============================================
+ Hits          78641    78645       +4     
+ Misses        40730    40278     -452     
+ Partials       5613     5591      -22     
Flag Coverage Δ
integration 0.00% <ø> (-0.01%) ⬇️
integration1 ?
integration2 0.00% <ø> (ø)
java-11 63.13% <ø> (+48.62%) ⬆️
java-17 14.52% <ø> (+0.02%) ⬆️
java-20 63.03% <ø> (+0.12%) ⬆️
temurin 63.16% <ø> (+0.24%) ⬆️
unittests 63.16% <ø> (+0.24%) ⬆️
unittests1 67.44% <ø> (+0.17%) ⬆️
unittests2 14.53% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../main/java/org/apache/pinot/client/Connection.java 77.50% <ø> (+7.04%) ⬆️
...inot/client/JsonAsyncHttpPinotClientTransport.java 29.82% <ø> (+1.95%) ⬆️
.../org/apache/pinot/client/PinotClientTransport.java 0.00% <ø> (ø)
...ava/org/apache/pinot/client/PreparedStatement.java 100.00% <ø> (+6.89%) ⬆️

... and 63 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@xiangfu0 xiangfu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xiangfu0 xiangfu0 merged commit 70a1335 into apache:master Sep 18, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated methods from pinot-java-client
4 participants