-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: add toggle to hide/show query exceptions #11611
UI: add toggle to hide/show query exceptions #11611
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11611 +/- ##
============================================
+ Coverage 63.15% 63.20% +0.05%
- Complexity 207 1104 +897
============================================
Files 2324 2324
Lines 124534 124534
Branches 18994 18994
============================================
+ Hits 78645 78710 +65
+ Misses 40302 40237 -65
Partials 5587 5587
Flags with carried forward coverage won't be shown. Click here to find out more. see 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do i need to do something to enable this? i compiled with latest pinot-controller module and it is still showing plain exception without the toggle
It should work, can you rebase the latest master and check again, with all the components to the latest. |
yes i did. i checked out and recompile from scratch. let me try it again after docker image release and report back. |
This is UI, enhancement
What does this PR do?
Screenshots
exceptions.mp4
exception.partial.mp4