Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null support for protobuf ingestion. #11553

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

shenyu0127
Copy link
Contributor

@shenyu0127 shenyu0127 commented Sep 9, 2023

If the protobuf field is NULL, we want to ingest the field as NULL.

  • A singular proto3 field can be optional or not. Only an optional singular field can be NULL.
  • A repeated proto3 field cannot be NULL, it can be an empty list.

Release-notes

Null support for protobuf ingestion: if the protobuf field is NULL, ingest the field as NULL.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Merging #11553 (00fc32a) into master (6208e7c) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #11553      +/-   ##
============================================
- Coverage     63.05%   63.04%   -0.02%     
+ Complexity     1109     1108       -1     
============================================
  Files          2320     2320              
  Lines        124667   124670       +3     
  Branches      19033    19033              
============================================
- Hits          78614    78601      -13     
- Misses        40458    40472      +14     
- Partials       5595     5597       +2     
Flag Coverage Δ
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 63.01% <100.00%> (+<0.01%) ⬆️
java-17 62.90% <100.00%> (-0.02%) ⬇️
java-20 62.91% <100.00%> (+0.01%) ⬆️
temurin 63.04% <100.00%> (-0.02%) ⬇️
unittests 63.04% <100.00%> (-0.02%) ⬇️
unittests1 67.45% <ø> (-0.03%) ⬇️
unittests2 14.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../inputformat/protobuf/ProtoBufRecordExtractor.java 80.43% <100.00%> (+1.78%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shenyu0127 shenyu0127 marked this pull request as ready for review September 9, 2023 04:56
@xiangfu0
Copy link
Contributor

Please add a release notes section for this.

@xiangfu0 xiangfu0 added release-notes Referenced by PRs that need attention when compiling the next release notes ingestion feature labels Sep 10, 2023
@shenyu0127
Copy link
Contributor Author

Please add a release notes section for this.

Done.

@xiangfu0 xiangfu0 merged commit 9c3a6e7 into apache:master Sep 10, 2023
21 checks passed
@xiangfu0
Copy link
Contributor

Thanks!

@shenyu0127 shenyu0127 deleted the protobuf-ingestion branch September 10, 2023 05:46
swaminathanmanish pushed a commit to swaminathanmanish/pinot that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ingestion release-notes Referenced by PRs that need attention when compiling the next release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants