Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multistage] Early terminate SortOperator if there is a limit #11334

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Aug 13, 2023

This is for join query or selection query without order by.
e.g.

SELECT a.col1, a.ts, b.col3 FROM a JOIN b ON a.col1 = b.col2 LIMIT 100

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2023

Codecov Report

Merging #11334 (932f182) into master (e4220ec) will decrease coverage by 47.24%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11334       +/-   ##
=============================================
- Coverage     61.50%   14.26%   -47.24%     
+ Complexity     6512      494     -6018     
=============================================
  Files          2233     2234        +1     
  Lines        120084   120155       +71     
  Branches      18223    18235       +12     
=============================================
- Hits          73853    17136    -56717     
- Misses        40828   101605    +60777     
+ Partials       5403     1414     -3989     
Flag Coverage Δ
integration1 0.00% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 14.24% <0.00%> (-47.24%) ⬇️
java-17 14.24% <0.00%> (-47.11%) ⬇️
java-20 14.25% <0.00%> (-47.12%) ⬇️
temurin 14.26% <0.00%> (-47.24%) ⬇️
unittests1 ?
unittests2 14.65% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...apache/pinot/query/mailbox/GrpcSendingMailbox.java 0.00% <0.00%> (ø)
...he/pinot/query/mailbox/InMemorySendingMailbox.java 0.00% <0.00%> (ø)
...g/apache/pinot/query/mailbox/ReceivingMailbox.java 0.00% <0.00%> (ø)
.../query/mailbox/channel/MailboxContentObserver.java 0.00% <0.00%> (ø)
.../pinot/query/runtime/blocks/TransferableBlock.java 0.00% <ø> (ø)
...ot/query/runtime/operator/MailboxSendOperator.java 0.00% <0.00%> (ø)
...che/pinot/query/runtime/operator/SortOperator.java 0.00% <0.00%> (ø)
...query/runtime/operator/exchange/BlockExchange.java 0.00% <0.00%> (ø)

... and 1398 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 force-pushed the early-term-sort-op branch 3 times, most recently from 3b7dfd3 to d3262af Compare August 13, 2023 23:43
@xiangfu0 xiangfu0 added enhancement multi-stage Related to the multi-stage query engine labels Aug 14, 2023
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes are not needed. Basically we want to make it a regular case where receiving mailbox can be closed before sending mailbox finishes all the blocks

@xiangfu0 xiangfu0 force-pushed the early-term-sort-op branch 2 times, most recently from 497da09 to 2c089de Compare August 15, 2023 06:53
@Jackie-Jiang Jackie-Jiang force-pushed the early-term-sort-op branch 2 times, most recently from 2ab8c2b to e737e90 Compare August 16, 2023 05:37
@Jackie-Jiang Jackie-Jiang force-pushed the early-term-sort-op branch 3 times, most recently from 15e2b6b to e37cfe3 Compare August 17, 2023 01:06
@Jackie-Jiang Jackie-Jiang merged commit b0c360a into apache:master Aug 17, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants