[vector] Adding vector functions #11222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xiangfu0
commented
Jul 30, 2023
•
xiangfu0
commented
- Support vector scalar functions, assuming vector type is stored as float[]
- cosine distance
- inner product
- l2 distance
- l1 distance
- vector dim
- vector norm
- Support both scalar and transform functions
- Add integration tests for v1/v2
xiangfu0
force-pushed
the
vector-functions
branch
from
53ff605
to
a052985
Compare
xiangfu0
changed the title
Codecov Report
@@ Coverage Diff @@
## master #11222 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2227 2229 +2
Lines 119628 119768 +140
Branches 18102 18126 +24
==========================================
Hits 137 137
- Misses 119471 119611 +140
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
force-pushed
the
vector-functions
branch
from
a052985
to
44b7b3e
Compare
xiangfu0
force-pushed
the
vector-functions
branch
from
44b7b3e
to
324a45c
Compare
xiangfu0
changed the title
xiangfu0
force-pushed
the
vector-functions
branch
3 times, most recently
from
cc8d9e4
to
a4c949d
Compare
KKcorps
reviewed
Jul 31, 2023
| norm1 += Math.pow(vector1[i], 2); | ||
| norm2 += Math.pow(vector2[i], 2); | ||
| } | ||
| return 1 - (dotProduct / (Math.sqrt(norm1) * Math.sqrt(norm2))); |
There was a problem hiding this comment.
Might need to check for divide by zero
There was a problem hiding this comment.
Make cosineDistance can take third optional argument default value, which is used when either vector has a norm of 0
KKcorps
reviewed
Jul 31, 2023
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/VectorFunctions.java
Outdated
Show resolved
Hide resolved
KKcorps
approved these changes
Jul 31, 2023
xiangfu0
force-pushed
the
vector-functions
branch
from
a4c949d
to
c178bb2
Compare
s0nskar
pushed a commit
to s0nskar/pinot
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.