Allow configuring helix timeouts for EV dropped in Instance manager #10510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10510 +/- ##
============================================
+ Coverage 63.23% 69.94% +6.70%
- Complexity 5905 6123 +218
============================================
Files 2036 2092 +56
Lines 110973 112716 +1743
Branches 16892 17143 +251
============================================
+ Hits 70177 78836 +8659
+ Misses 35606 28314 -7292
- Partials 5190 5566 +376
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 414 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Mar 30, 2023
| @@ -205,7 +202,7 @@ private TableDataManager createTableDataManager(String tableNameWithType, TableC | |||
| public void deleteTable(String tableNameWithType) | |||
| throws Exception { | |||
| // Wait externalview to converge | |||
| long endTimeMs = System.currentTimeMillis() + EXTERNAL_VIEW_DROPPED_MAX_WAIT_MS; | |||
| long endTimeMs = System.currentTimeMillis() + _instanceDataManagerConfig.getExternalViewDroppedMaxWaitMs(); | |||
There was a problem hiding this comment.
(minor) Let's cache these 2 values into local variable (or as member variable during init())
| // Check if the external view is dropped for a table, and if so, wait for the external view to | ||
| // be updated for a maximum of this time. | ||
| private static final String EXTERNAL_VIEW_DROPPED_MAX_WAIT_MS = "external.view.dropped.max.wait.ms"; | ||
| private static final String EXTERNAL_VIEW_CHECK_INTERVAL_MS = "external.view.check.interval.ms"; |
There was a problem hiding this comment.
(minor)
Suggested change
| private static final String EXTERNAL_VIEW_CHECK_INTERVAL_MS = "external.view.check.interval.ms"; | |
| private static final String EXTERNAL_VIEW_DROPPED_CHECK_INTERVAL_MS = "external.view.dropped.check.interval.ms"; |
Jackie-Jiang
added
the
Configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can set the following configs to configure the timeout
external.view.dropped.max.wait.ms- The duration of time in milliseconds to wait for the external view to be dropped. Default - 20 minutes.external.view.check.interval.ms- The period in milliseconds in which to ping ZK for latest EV state.