Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/s3: Remove the requirement for region #56

Closed
Tracked by #3
Xuanwo opened this issue Feb 24, 2022 · 1 comment
Closed
Tracked by #3

backend/s3: Remove the requirement for region #56

Xuanwo opened this issue Feb 24, 2022 · 1 comment

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Feb 24, 2022

export S3_STORAGE_ENDPOINT_URL=https://s3.amazonaws.com

It's buggy now.

The behavior between keeping S3_STORAGE_ENDPOINT_URL empty and setting S3_STORAGE_ENDPOINT_URL=https://s3.amazonaws.com/ is different.

  • S3_STORAGE_ENDPOINT_URL="": s3 SDK will use format!("s3.{}.amazonaws.com", region) to construct the correct endpoint.
  • S3_STORAGE_ENDPOINT_URL=https://s3.amazonaws.com/: s3 SDK will take this input as static, and can't handle the region correctly.

I'm considering removing the region option so that:

  • For AWS S3, we can always use https://s3.amazonaws.com/ and detect the region for users.
  • For other services, we can let user input the correct endpoint like http://127.0.0.1:9000

Originally posted by @Xuanwo in #54 (comment)

@Xuanwo
Copy link
Member Author

Xuanwo commented Feb 24, 2022

Implemented in #59

@Xuanwo Xuanwo closed this as completed Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant