-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This reverts commit 02433c5.
e5c17cd
to
f38bee4
Compare
@@ -111,7 +111,7 @@ def run_notebook(notebook, notebook_dir, kernel=None, no_cache=False, temp_dir=' | |||
nbformat.write(notebook, output_file) | |||
output_nb = io.open(output_file, mode='r', encoding='utf-8') | |||
for line in output_nb: | |||
if "Warning:" in line: | |||
if "Warning:" in line and "numpy operator signatures" not in line: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning message of numpy operator signature
is for python version < 3.5. It does not affect functionality, but merely used for building numpy op documentation. I'm fine with this change.
@ThomasDelteil @larroy ping for review |
@marcoabreu can you please review and merge. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix @mseth10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -29,6 +29,7 @@ COPY install/deb_ubuntu_ccache.sh /work/ | |||
RUN /work/deb_ubuntu_ccache.sh | |||
|
|||
COPY install/ubuntu_python.sh /work/ | |||
COPY install/requirements /work/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the test environment is in the '/work/` directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, work directory is created inside the docker and all required files are copied there.
* copy missing requirements file * not treating numpy warnings as errors * updating six package version * Revert "updating six package version" This reverts commit 02433c5.
Description
This PR fixes nightly tests for binaries, that have been failing since 09/19.
One of the errors is because requirements file was not copied to the teat environment.
The other errors are due to numpy warnings treated as errors.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments