This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haojin2
reviewed
Aug 27, 2019
haojin2
reviewed
Aug 27, 2019
haojin2
reviewed
Aug 27, 2019
xiezhq-hermann
force-pushed
the
master
branch
2 times, most recently
from
August 27, 2019 06:53
dd0e2f4
to
072f38e
Compare
xiezhq-hermann
force-pushed
the
master
branch
from
September 2, 2019 08:17
072f38e
to
61a4cc9
Compare
comaniac
suggested changes
Sep 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to master and solve conflicts after resolving the comments.
append and prepend not supported yet remove the prepend and append checking interface from the backend refine the code, enrich the test set and all tests passed registered the diff operator into npi scope all tests passed comments and minor modification format codes and fix warning for sanity check minor modification for sanity check fix sanity fix the tolerance bound of testing np.diff resolve minor coding style issue replace the given tests by random picking minor fix
xiezhq-hermann
force-pushed
the
master
branch
from
October 28, 2019 17:47
61a4cc9
to
5d1f516
Compare
haojin2
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
haojin2
pushed a commit
that referenced
this pull request
Oct 31, 2019
* implement np.column_stack * cpplint * remove column_stack from numpy interoperability test temporarily * style and test fix * fix pylint and add interoperability test * fix doc string, add comment, remove dead code * pylint * ci * ci * ci * [Numpy] Numpy operator diff (#15906) * numpy diff operator implemented append and prepend not supported yet remove the prepend and append checking interface from the backend refine the code, enrich the test set and all tests passed registered the diff operator into npi scope all tests passed comments and minor modification format codes and fix warning for sanity check minor modification for sanity check fix sanity fix the tolerance bound of testing np.diff resolve minor coding style issue replace the given tests by random picking minor fix * interoperability test added * implement np.column_stack * cpplint * remove column_stack from numpy interoperability test temporarily * style and test fix * fix pylint and add interoperability test * fix doc string, add comment, remove dead code * pylint * ci * ci * ci * rebase resolve conflicts * pylint
yajiedesign
pushed a commit
to yajiedesign/mxnet
that referenced
this pull request
Nov 6, 2019
* numpy diff operator implemented append and prepend not supported yet remove the prepend and append checking interface from the backend refine the code, enrich the test set and all tests passed registered the diff operator into npi scope all tests passed comments and minor modification format codes and fix warning for sanity check minor modification for sanity check fix sanity fix the tolerance bound of testing np.diff resolve minor coding style issue replace the given tests by random picking minor fix * interoperability test added
yajiedesign
pushed a commit
to yajiedesign/mxnet
that referenced
this pull request
Nov 6, 2019
* implement np.column_stack * cpplint * remove column_stack from numpy interoperability test temporarily * style and test fix * fix pylint and add interoperability test * fix doc string, add comment, remove dead code * pylint * ci * ci * ci * [Numpy] Numpy operator diff (apache#15906) * numpy diff operator implemented append and prepend not supported yet remove the prepend and append checking interface from the backend refine the code, enrich the test set and all tests passed registered the diff operator into npi scope all tests passed comments and minor modification format codes and fix warning for sanity check minor modification for sanity check fix sanity fix the tolerance bound of testing np.diff resolve minor coding style issue replace the given tests by random picking minor fix * interoperability test added * implement np.column_stack * cpplint * remove column_stack from numpy interoperability test temporarily * style and test fix * fix pylint and add interoperability test * fix doc string, add comment, remove dead code * pylint * ci * ci * ci * rebase resolve conflicts * pylint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Numpy compatible operator diff
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
Thank you for your effort to review! @haojin2 @reminisce