This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6543488.
@mxnet-label-bot add [pr-work-in-progress] |
anirudh2290
changed the title
[WIP] FP16 Support for C Predict API
FP16 Support for C Predict API
Jun 20, 2019
anirudh2290
changed the title
FP16 Support for C Predict API
[WIP] FP16 Support for C Predict API
Jun 24, 2019
anirudh2290
changed the title
[WIP] FP16 Support for C Predict API
FP16 Support for C Predict API
Jun 29, 2019
sandeep-krishnamurthy
removed
the
pr-work-in-progress
PR is still work in progress
label
Jul 2, 2019
sandeep-krishnamurthy
previously requested changes
Jul 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this great work.
Few comments and questions.
…to FP16_predict
sandeep-krishnamurthy
dismissed
their stale review
July 3, 2019 22:51
Overall looks good to me. Waiting for test cases.
thank you! |
sandeep-krishnamurthy
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
samskalicky
pushed a commit
to samskalicky/incubator-mxnet
that referenced
this pull request
Aug 28, 2019
* Upgrade archive utility and add back FC improvement This reverts commit 6543488. * Change permissions for Ubuntu AR * Extract and cd into binutils dir * Allow AR path to be chosen by user * Add AR path to build * Fix AR paths * Revert AR flag in makefile * Build from source doc updated * Commit for C Predict API * Add FP16 predict support * Add Test Predictor fixes * Add test for predictor * Cleanup fixes * Fixes * Add support for forward pass only for gpu * Fix Reshape, move test to gpu * Add monitor callback for C Predict API * Add tests, default dtype and set_monitor_callback * Improve error * Fix c_str_array
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds dtype support for C Predict API.
Fixes: #14159 and #13335
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments