Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy Diag in MXNet #9253

Closed
sxjscience opened this issue Dec 29, 2017 · 4 comments
Closed

Numpy Diag in MXNet #9253

sxjscience opened this issue Dec 29, 2017 · 4 comments
Labels
Call for Contribution Operator

Comments

@sxjscience
Copy link
Member

sxjscience commented Dec 29, 2017 •
edited
Loading

Borrow from https://discuss.gluon.ai/t/topic/3846.

We can consider to implement np.diag in the future.
https://docs.scipy.org/doc/numpy-1.13.0/reference/generated/numpy.diag.html
@sxjscience sxjscience mentioned this issue Mar 30, 2018
Closed
@ifeherva
Copy link
Contributor

I am interested implementing this, is there a jira issue already?

@sxjscience
Copy link
Member Author

@ifeherva NoJIRA issue for this one yet.

@ifeherva
Copy link
Contributor

ifeherva commented Jul 8, 2018 •
edited
Loading

I am working on replicating np.diag(). Once done will do the full diagonal operator. This is my first operator so I am learning a lot at the moment.

  • 2d forward pass CPU
  • 2d forward pass GPU
  • 1d forward pass CPU
  • 1d forward pass GPU
  • 2d backward pass CPU
  • 2d backward pass GPU
  • 1d backward pass CPU
  • 1d backward pass GPU
  • unit tests

PR:
#11643

@samskalicky
Copy link
Contributor

@eric-haibin-lin This issue can be closed now that the PR has been merged

@samskalicky samskalicky mentioned this issue Aug 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Call for Contribution Operator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samskalicky @ifeherva @sxjscience @eric-haibin-lin