chore(api): support ignore graphspaces segment in url #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
VGalaxies
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2612 +/- ##
============================================
+ Coverage 45.17% 48.69% +3.52%
- Complexity 583 708 +125
============================================
Files 718 730 +12
Lines 58434 59532 +1098
Branches 7491 7662 +171
============================================
+ Hits 26396 28992 +2596
+ Misses 29318 27630 -1688
- Partials 2720 2910 +190 ☔ View full report in Codecov by Sentry. |
39 tasks
javeme
reviewed
Aug 10, 2024
...aph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/GraphSpaceFilter.java
Outdated
Show resolved
Hide resolved
...aph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/GraphSpaceFilter.java
Show resolved
Hide resolved
...aph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/GraphSpaceFilter.java
Outdated
Show resolved
Hide resolved
...aph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/GraphSpaceFilter.java
Outdated
Show resolved
Hide resolved
...aph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/GraphSpaceFilter.java
Outdated
Show resolved
Hide resolved
...aph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/GraphSpaceFilter.java
Outdated
Show resolved
Hide resolved
| String relativePathStr = relativePath.getPath(); | ||
| // TODO: remember change the logic after we support "GraphSpace" | ||
| if (relativePathStr.startsWith("graphspaces/")) { | ||
| // Step 2: Extract the next substring after "graphspaces/" |
There was a problem hiding this comment.
can we add a api-test case for this code branch
There was a problem hiding this comment.
see GraphSpaceVertexApiTest and GraphSpaceEdgeApiTest, could be more...
dosubot
bot
added
size:L
imbajin
reviewed
Aug 12, 2024
| @@ -84,6 +84,7 @@ public static void init() { | |||
| @AfterClass | |||
| public static void clear() throws Exception { | |||
| client.close(); | |||
| client = null; | |||
There was a problem hiding this comment.
No special meaning, just set the client member variable to null to indicate that the closed client should not be used anymore.
simon824
approved these changes
Aug 13, 2024
imbajin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.