-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server):swagger support auth for standardAuth mode #2360
Conversation
…x arthas odd test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2360 +/- ##
============================================
- Coverage 64.32% 63.43% -0.90%
+ Complexity 981 826 -155
============================================
Files 507 507
Lines 42073 42073
Branches 5831 5831
============================================
- Hits 27065 26687 -378
- Misses 12317 12685 +368
- Partials 2691 2701 +10 ☔ View full report in Codecov by Sentry. |
@@ -72,7 +72,8 @@ public class AuthenticationFilter implements ContainerRequestFilter { | |||
|
|||
private static final List<String> WHITE_API_LIST = ImmutableList.of( | |||
"auth/login", | |||
"versions" | |||
"versions", | |||
"openapi.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we add swagger file to white_list by default to allow normal users to check the api & not locked by auth
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/server/ApplicationConfig.java
Show resolved
Hide resolved
One more thing, we need update apiversion for metrics & arthas API here: (use 0.70 for them maybe?) Also search Note we can trace API changes through the commits history: https://github.com/apache/incubator-hugegraph/commits/27c0d1026ac85336b13137458e38950f3b1a43bb/hugegraph-api/src/main/java/org/apache/hugegraph/api |
please also supplement apiversion for #2242 |
seems [0.70] |
both fine to me(#number is also acceptable but not sure for others opinion),u could try modify it |
* feat(server):swagger support auth for standardAuth mode and try to fix arthas odd test * chore(api): update api version & swagger token auth mode
…x arthas odd test
Purpose of the PR
swagger support auth for standardAuth mode and try to fix arthas odd test
Main Changes
Verifying these changes
no auth model,we can try it out in swagger:
auth model,we cant try it out in swagger:
after set auth info,success:
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need