feat: adapt Dockerfile for new project structure #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbajin
reviewed
Nov 8, 2023
| RUN chmod 755 ./docker-entrypoint.sh | ||
|
|
||
| EXPOSE 8080 | ||
| VOLUME /hugegraph | ||
| VOLUME /hugegraph-server | ||
|
|
||
| ENTRYPOINT ["/usr/bin/dumb-init", "--"] | ||
| CMD ["./docker-entrypoint.sh"] |
There was a problem hiding this comment.
also test docker stop & docker start here for server
There was a problem hiding this comment.
https://hugegraph.feishu.cn/wiki/ThvlwPUHNiCpwPkjurkcw4mBnpf
tested.
Stop and start the server the data did not change.
But if i change the server image to the new version, it stuck when loading:
Codecov Report
@@ Coverage Diff @@
## master #2344 +/- ##
============================================
- Coverage 66.22% 61.11% -5.12%
+ Complexity 983 981 -2
============================================
Files 507 507
Lines 42073 42073
Branches 5831 5831
============================================
- Hits 27862 25712 -2150
- Misses 11504 13789 +2285
+ Partials 2707 2572 -135 see 94 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
imbajin
approved these changes
Nov 13, 2023
simon824
approved these changes
Nov 13, 2023
VGalaxies
pushed a commit
to VGalaxies/incubator-hugegraph
that referenced
this pull request
Jan 12, 2024
* feat: dockerfile adapt the project structure * change the version --------- Co-authored-by: imbajin <jin@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
It affects the action file, which has been changed.
https://github.com/hugegraph/actions/blob/master/.github/workflows/publish_latest_server_image.yml
Documentation Status
Doc - TODODoc - DoneDoc - No Need