fix: assemble executable jar for pd and store #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
|
could also refer the toolchain PR: (Although not same) |
imbajin
reviewed
Aug 21, 2023
hugegraph-pd/hg-pd-service/pom.xml
Outdated
Comment on lines
141
to
153
| <classifier>spring-boot</classifier> | ||
| <mainClass> | ||
| org.apache.hugegraph.pd.boot.HugePDServer | ||
| </mainClass> | ||
| </configuration> | ||
| <goals> | ||
| <goal>repackage</goal> | ||
| </goals> |
There was a problem hiding this comment.
There was a problem hiding this comment.
refer to docs.spring.io/spring-boot/docs/current/maven-plugin/reference/htmlsingle/#packaging
fine, better to add url refer for it in future, currently leave this in PR context
hugegraph-pd/hg-pd-dist/src/assembly/static/bin/start-hugegraph-pd.sh
Outdated
Show resolved
Hide resolved
11 tasks
imbajin
reviewed
Aug 29, 2023
| @@ -114,8 +114,8 @@ fi | |||
| echo "Starting HugeGraphPDServer..." | |||
|
|
|||
| # Turn on security check | |||
| exec ${JAVA} ${JAVA_OPTIONS} -jar -Dspring.config.location=${CONF}/application.yml \ | |||
| ${LIB}/hugegraph-pd-*.jar >> ${OUTPUT} 2>&1 & | |||
| exec ${JAVA} -Dname="HugeGraphPd" ${JAVA_OPTIONS} -jar \ | |||
There was a problem hiding this comment.
Suggested change
| exec ${JAVA} -Dname="HugeGraphPd" ${JAVA_OPTIONS} -jar \ | |
| exec ${JAVA} -Dname="HugeGraphPD" ${JAVA_OPTIONS} -jar \ |
TODO:
@VGalaxies we could better get the jar version for the suffix of name, like HugeGraphServer-1.0 | HugeGraphPD-1.5 to let users know the version directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
fix #2275
refer to https://hugegraph.feishu.cn/wiki/UfL0w2m8Aiekl9kHsedc8jQKnN7#QuiKdmz2ZoY3WMxqkiaczvc6nKb
Main Changes
Due to the change of
hugegraph-pd's parent fromspring-boot-starter-parenttohugegraph, andhugegraph's parent beingapache, along with modifications to theartifactIdof certain sub-modules (for example,hugegraph-pdtohg-pd-service), the following steps need to be taken:maven-assembly-plugin, which involves adjusting the collected jar package names accordingly.hugegraph-pdis started using Spring Boot, thespring-boot-maven-pluginneeds to be reconfigured.Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need