Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): close flat mapper iterator after usage #2281

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

qwtsc
Copy link
Contributor

@qwtsc qwtsc commented Aug 14, 2023

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@imbajin imbajin requested review from javeme and zyxxoo August 14, 2023 10:22
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #2281 (4862a70) into master (b02c2bd) will decrease coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2281      +/-   ##
============================================
- Coverage     68.63%   68.58%   -0.05%     
  Complexity      977      977              
============================================
  Files           498      498              
  Lines         40684    40685       +1     
  Branches       5681     5681              
============================================
- Hits          27922    27904      -18     
- Misses        10056    10078      +22     
+ Partials       2706     2703       -3     
Files Changed Coverage Δ
.../hugegraph/traversal/algorithm/CountTraverser.java 72.72% <100.00%> (+0.50%) ⬆️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qwtsc
Copy link
Contributor Author

qwtsc commented Aug 14, 2023

Force-push note: clean the unused imports

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin changed the title fix: close flat mapper iterator after usage fix(core): close flat mapper iterator after usage Aug 21, 2023
@imbajin imbajin merged commit aaf67cf into apache:master Aug 29, 2023
19 of 21 checks passed
DanGuge pushed a commit to DanGuge/incubator-hugegraph that referenced this pull request Sep 25, 2023
close [Bug] FlatMapperIterator should be closed after usage apache#2280
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Nov 10, 2023
close [Bug] FlatMapperIterator should be closed after usage apache#2280
imbajin pushed a commit that referenced this pull request Nov 10, 2023
close [Bug] FlatMapperIterator should be closed after usage #2280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] FlatMapperIterator should be closed after usage
4 participants