Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): exclude binary file in clean plugin #2052

Merged
merged 1 commit into from
Dec 15, 2022
Merged

fix(test): exclude binary file in clean plugin #2052

merged 1 commit into from
Dec 15, 2022

Conversation

zyxxoo
Copy link
Contributor

@zyxxoo zyxxoo commented Dec 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #2052 (162693a) into master (9cbb618) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2052   +/-   ##
=========================================
  Coverage     68.41%   68.41%           
- Complexity      976      978    +2     
=========================================
  Files           481      481           
  Lines         39749    39749           
  Branches       5582     5582           
=========================================
+ Hits          27193    27195    +2     
+ Misses         9929     9926    -3     
- Partials       2627     2628    +1     
Impacted Files Coverage Δ
...hugegraph/backend/store/raft/rpc/RpcForwarder.java 69.49% <0.00%> (-1.70%) ⬇️
...a/org/apache/hugegraph/task/ServerInfoManager.java 75.00% <0.00%> (+1.74%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: move binary to target/ later & improve the plugin settings (current is misunderstand)

<excludes>
<exclude>${final.name}/**</exclude>
<exclude>*.tar.gz</exclude>
<exclude>*.zip</exclude>
Copy link
Member

@imbajin imbajin Dec 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems no need for zip? (update it in future)

@imbajin imbajin changed the title fix: keep binary file fix(test): exclude binary file in clean plugin Dec 15, 2022
@imbajin imbajin added the ci-cd Build or deploy label Dec 15, 2022
@zyxxoo zyxxoo merged commit 85499f3 into master Dec 15, 2022
@zyxxoo zyxxoo deleted the zy_dev branch December 15, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants