Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][cli] Fix start cli error #2024

Merged
merged 6 commits into from
Nov 22, 2022
Merged

[fix][cli] Fix start cli error #2024

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b3bff4c
Fix start shell
coderzc Nov 20, 2022
05d49f1
Merge branch 'master' into fix_start_shell
imbajin Nov 20, 2022
9abf989
Fix start shell
coderzc Nov 20, 2022
c7e8ea9
address comment
coderzc Nov 21, 2022
58e8bf9
Update hugegraph
imbajin Nov 21, 2022
3c88b2d
Merge branch 'master' into fix_start_shell
javeme Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hugegraph-dist/src/assembly/static/bin/hugegraph
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,13 @@
### END INIT INFO

# Variables
# it requires user to set a fixed abs path manually
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can try ${INSTALL_DIR:?"Please setting variables 'INSTALL_DIR'"}
for more details: https://stackoverflow.com/a/16753536

Copy link
Member

@imbajin imbajin Nov 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/a/16753536

@javeme seems a little strange, could it use directly or test it in local evn? (or should in a if condition?)

image

and it alert:
image

failed with all cases in my ubuntu21

INSTALL_DIR=
SERVER_PORT=

${INSTALL_DIR:?"Please set variables 'INSTALL_DIR'"}
${SERVER_PORT:?"Please set variables 'SERVER_PORT'"}

BIN_DIR=$INSTALL_DIR/bin
SERVER_URL="http://localhost:${SERVER_PORT}"
DETECT_URL="$SERVER_URL/versions"
Expand Down