Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth fix: don't ignore permission exception in parseEntry() #1380

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Mar 8, 2021

Change-Id: I115127904df3e4d3a18ded6b4638bdbde87bd2a5

Change-Id: I115127904df3e4d3a18ded6b4638bdbde87bd2a5
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #1380 (485e0a4) into master (b4c767b) will decrease coverage by 6.82%.
The diff coverage is 41.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1380      +/-   ##
============================================
- Coverage     69.19%   62.36%   -6.83%     
- Complexity     5401     5828     +427     
============================================
  Files           328      385      +57     
  Lines         26334    31955    +5621     
  Branches       3750     4460     +710     
============================================
+ Hits          18222    19929    +1707     
- Misses         6333    10004    +3671     
- Partials       1779     2022     +243     
Impacted Files Coverage Δ Complexity Δ
...api/src/main/java/com/baidu/hugegraph/api/API.java 69.04% <ø> (+3.49%) 0.00 <0.00> (ø)
...n/java/com/baidu/hugegraph/api/auth/AccessAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/com/baidu/hugegraph/api/auth/BelongAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/com/baidu/hugegraph/api/auth/GroupAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/com/baidu/hugegraph/api/auth/TargetAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ain/java/com/baidu/hugegraph/api/auth/UserAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...com/baidu/hugegraph/api/gremlin/GremlinClient.java 90.90% <ø> (ø) 0.00 <0.00> (ø)
.../java/com/baidu/hugegraph/api/job/ComputerAPI.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/com/baidu/hugegraph/api/job/GremlinAPI.java 50.72% <ø> (+33.33%) 0.00 <0.00> (ø)
...va/com/baidu/hugegraph/api/metrics/MetricsAPI.java 65.78% <ø> (ø) 0.00 <0.00> (ø)
... and 372 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a50c4c8...485e0a4. Read the comment docs.

@zhoney zhoney merged commit 8bda451 into master Mar 9, 2021
@zhoney zhoney deleted the auth-fix-parseEntry-ignore-permission-error branch March 9, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants