upgrade store version due to read frequency of property key #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ie8643276d572e7eabee24f13ea0ee4ac38e60e5b
Codecov Report
@@ Coverage Diff @@
## master #1341 +/- ##
============================================
- Coverage 62.30% 62.30% -0.01%
- Complexity 5799 5802 +3
============================================
Files 379 379
Lines 31664 31680 +16
Branches 4435 4438 +3
============================================
+ Hits 19729 19737 +8
- Misses 9930 9933 +3
- Partials 2005 2010 +5
Continue to review full report at Codecov.
|
javeme
reviewed
Jan 19, 2021
| assert entry.type().isSchema(); | ||
|
|
||
| T column = entry.column(key); | ||
| E.checkState(column != null, "Not found key '%s' from entry %s", |
| Number dataType = schemaColumn(entry, HugeKeys.DATA_TYPE); | ||
| Number cardinality = schemaColumn(entry, HugeKeys.CARDINALITY); | ||
| Number aggregateType = schemaColumn(entry, HugeKeys.AGGREGATE_TYPE); | ||
| Number readFrequency = schemaColumn(entry, HugeKeys.READ_FREQUENCY); |
There was a problem hiding this comment.
how to deal with can't get version-info from old version backend
javeme
reviewed
Jan 19, 2021
| return value; | ||
| } | ||
|
|
||
| private <T extends SerialEnum> T schemaEnum(TableBackendEntry entry, |
javeme
approved these changes
Jan 21, 2021
Linary
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ie8643276d572e7eabee24f13ea0ee4ac38e60e5b