Adapt jraft 1.3.5 #1313
Merged
Adapt jraft 1.3.5 #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: In fact, it still cann't fully adapt to the community version of jraft,
because it's different from the rocksdb version that hugegraph relies on
Change-Id: I83079e799df4d332e968694c7aea0ff11bbcdb81
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
============================================
+ Coverage 61.67% 62.33% +0.66%
- Complexity 5752 5772 +20
============================================
Files 377 377
Lines 31501 31504 +3
Branches 4413 4412 -1
============================================
+ Hits 19428 19638 +210
+ Misses 10088 9873 -215
- Partials 1985 1993 +8
Continue to review full report at Codecov.
|
javeme
requested changes
Dec 25, 2020
| @@ -683,11 +684,17 @@ public synchronized void destroy() { | |||
| private WriteOptions writeOptions; | |||
|
|
|||
| public StdSession(HugeConfig conf) { | |||
| boolean bulkload = conf.get(RocksDBOptions.BULKLOAD_MODE); | |||
| boolean raftMode = conf.get(CoreOptions.RAFT_MODE); | |||
Change-Id: I8878b88acb02369dcb8cc2f57871f88d98bc3203
Linary
force-pushed
the
adapt-jraft-1.3.5
branch
from
3203540
to
c17c104
Compare
Linary
changed the title
javeme
requested changes
Dec 28, 2020
| @@ -65,6 +65,7 @@ | |||
| import com.baidu.hugegraph.backend.store.BackendEntry.BackendColumn; | |||
| import com.baidu.hugegraph.backend.store.BackendEntry.BackendColumnIterator; | |||
| import com.baidu.hugegraph.backend.store.BackendEntryIterator; | |||
| import com.baidu.hugegraph.config.CoreOptions; | |||
Change-Id: Id459b0087025d75a13a84791b158d1d093fc3f7b
javeme
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: In fact, it still cann't fully adapt to the community version of jraft,
because it's different from the rocksdb version that hugegraph relies on
Change-Id: I83079e799df4d332e968694c7aea0ff11bbcdb81