Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hbase/rocksdb shard bug #1306

Merged
merged 3 commits into from
Dec 25, 2020
Merged

fix hbase/rocksdb shard bug #1306

merged 3 commits into from
Dec 25, 2020

Conversation

zhoney
Copy link
Contributor

@zhoney zhoney commented Dec 21, 2020

Change-Id: Ifce3d450712104c067a57c361351c9e047bc0cfa

Change-Id: Ifce3d450712104c067a57c361351c9e047bc0cfa
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #1306 (c36d768) into master (f0d1146) will increase coverage by 0.22%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1306      +/-   ##
============================================
+ Coverage     62.11%   62.33%   +0.22%     
  Complexity     5772     5772              
============================================
  Files           377      377              
  Lines         31501    31502       +1     
  Branches       4413     4412       -1     
============================================
+ Hits          19566    19638      +72     
+ Misses         9946     9871      -75     
- Partials       1989     1993       +4     
Impacted Files Coverage Δ Complexity Δ
...om/baidu/hugegraph/backend/store/BackendTable.java 73.33% <75.00%> (+48.50%) 11.00 <0.00> (ø)
...aidu/hugegraph/backend/store/hbase/HbaseTable.java 78.75% <100.00%> (ø) 37.00 <0.00> (ø)
...a/com/baidu/hugegraph/backend/query/Condition.java 78.38% <0.00%> (-0.37%) 32.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d1146...c36d768. Read the comment docs.

javeme
javeme previously approved these changes Dec 21, 2020
List<Shard> shards = new ArrayList<>(count);
while (Bytes.compare(offset, end) < 0) {
while (Bytes.compare(offset, end) < 0 && !finished) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the test not covered? prefer to add one test case

Change-Id: I75b33c8cff9c7e48fc8f44e9e175f9365a143ee3
Change-Id: I7cbdaccf8a79227bcac2bdb953e11faf2e6da69b
@zhoney zhoney merged commit 0f15c46 into master Dec 25, 2020
@zhoney zhoney deleted the fix-hbase-shard branch December 25, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants