Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] validate-release.sh improvement on Mac #2110

Open
1 task done
javeme opened this issue Feb 12, 2023 · 9 comments · Fixed by apache/incubator-hugegraph-doc#197
Open
1 task done

[Bug] validate-release.sh improvement on Mac #2110

javeme opened this issue Feb 12, 2023 · 9 comments · Fixed by apache/incubator-hugegraph-doc#197
Assignees
Labels
bug Something isn't working shell Issues about shell script

Comments

@javeme
Copy link
Contributor

javeme commented Feb 12, 2023

Bug Type (问题类型)

others (please edit later)

Before submit

  • 我已经确认现有的 IssuesFAQ 中没有相同 / 重复问题

Environment (环境信息)

  • apache 1.0.0-rc2
  • mac m1

Expected & Actual behavior (期望与实际表现)

  1. should echo which package name when check incubating name(fixed by: https://github.com/apache/incubator-hugegraph-doc/blame/release-1.2.0/dist/validate-release.sh#L89):
    The package name 'xx' should include incubating
    The package name *src.tar.gz should include incubating

  2. error of cd ./*toolchain*(fixed by: https://github.com/apache/incubator-hugegraph-doc/blame/release-1.2.0/dist/validate-release.sh#L179):
    ./validate-release.sh: line 45: cd: ./*toolchain*: No such file or directory

  3. not stop validate even if there are compile errors(fixed by: https://github.com/apache/incubator-hugegraph-doc/blame/release-1.2.0/dist/validate-release.sh#L154):
    mvn package -DskipTests -ntp && ls -lh

  4. need to stop the server after test(fixed by: https://github.com/apache/incubator-hugegraph-doc/blame/release-1.2.0/dist/validate-release.sh#L210):
    While lock file: rocksdb-data/m/LOCK: Resource temporarily unavailable

  5. need to check hubble-dist env dependency(to check):
    check or auto install yarm for hubble:
    [Bug] validate-release.sh improvement on Mac #2110 (comment)

  6. need to check wget command(to check):

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (download-swagger-ui) on project hugegraph-dist: An Ant BuildException has occured: exec returned: 1

[INFO] --- maven-antrun-plugin:1.8:run (download-swagger-ui) @ hugegraph-dist ---
[WARNING] Parameter tasks is deprecated, use target instead
[INFO] Executing tasks

main:
     [exec] ./dist.sh: line 1: wget: command not found
     [exec] tar: Error opening archive: Failed to open 'v4.15.5.tar.gz'
     [exec] ./dist.sh: line 6: swagger-ui-4.15.5/dist/swagger-initializer.js: No such file or directory
     [exec] cp: swagger-ui-4.15.5/dist: No such file or directory

Vertex/Edge example (问题点 / 边数据举例)

No response

Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)

No response

@javeme javeme added bug Something isn't working shell Issues about shell script labels Feb 12, 2023
@javeme
Copy link
Contributor Author

javeme commented Feb 12, 2023

hugegraph-loader compile WARNING and block

[INFO] Building hugegraph-loader 1.0.0                                    [3/8]
[INFO] --------------------------------[ jar ]---------------------------------
[WARNING] Could not transfer metadata net.minidev:json-smart/maven-metadata.xml from/to maven-default-http-blocker (http://0.0.0.0/): transfer failed for http://0.0.0.0/net/minidev/json-smart/maven-metadata.xml
[WARNING] The POM for org.glassfish:javax.el:jar:3.0.1-b06-SNAPSHOT is missing, no dependency information available
[WARNING] The POM for org.glassfish:javax.el:jar:3.0.1-b07-SNAPSHOT is missing, no dependency information available
[WARNING] The POM for org.glassfish:javax.el:jar:3.0.1-b08-SNAPSHOT is missing, no dependency information available
[WARNING] The POM for org.glassfish:javax.el:jar:3.0.1-b11-SNAPSHOT is missing, no dependency information available

fixed by set blocked to false in MVN_HOME/conf/settings.xml

    <mirror>
      <id>maven-default-http-blocker</id>
      <mirrorOf>external:http:*</mirrorOf>
      <name>Pseudo repository to mirror external repositories initially using HTTP.</name>
      <url>http://0.0.0.0/</url>
      <blocked>false</blocked>
    </mirror>

https://stackoverflow.com/questions/69400875/maven-stuck-downloading-maven-default-http-blocker

@javeme
Copy link
Contributor Author

javeme commented Feb 12, 2023

hubble-dist build error:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for hugegraph-toolchain 1.0.0:
[INFO] 
[INFO] hugegraph-toolchain ................................ SUCCESS [  1.135 s]
[INFO] hugegraph-client ................................... SUCCESS [  1.148 s]
[INFO] hugegraph-loader ................................... SUCCESS [06:38 min]
[INFO] hugegraph-tools .................................... SUCCESS [03:10 min]
[INFO] hugegraph-hubble ................................... SUCCESS [  0.034 s]
[INFO] hubble-be .......................................... SUCCESS [22:00 min]
[INFO] hubble-dist ........................................ FAILURE [  3.214 s]
[INFO] hugegraph-dist ..................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  31:55 min
[INFO] Finished at: 2023-02-12T23:33:49+08:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (default) on project hubble-dist: An Ant BuildException has occured: exec returned: 1
[ERROR] around Ant part ...<exec failonerror="true" dir="hg/apache-hugegraph-toolchain-incubating-1.0.0-src/hugegraph-hubble/hubble-dist/.." executable="bash">... @ 18:158 in hg/apache-hugegraph-toolchain-incubating-1.0.0-src/hugegraph-hubble/hubble-dist/target/antrun/build-main.xml
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :hubble-dist
total 1382600

can we show some error message of the cause?

@imbajin
Copy link
Member

imbajin commented Feb 13, 2023

fixed some of them in apache/incubator-hugegraph-doc#197, problem 2 can't reproduced (maybe related to the BASH env)

@javeme
Copy link
Contributor Author

javeme commented Feb 13, 2023

@imbajin issue 2 is related to zsh, we can fixed by cd $(echo ./*toolchain*-1.0.0):

zsh $ echo ./*toolchain*
./apache-hugegraph-toolchain-incubating-1.0.0 ./apache-hugegraph-toolchain-incubating-1.0.0.tar.gz

zsh $ echo ./*toolchain*-1.0.0
./apache-hugegraph-toolchain-incubating-1.0.0

zsh $ cd ./*toolchain*          
cd: string not in pwd: ./apache-hugegraph-toolchain-incubating-1.0.0

zsh $ cd $(echo ./*toolchain*-1.0.0)
apache-hugegraph-toolchain-incubating-1.0.0

@imbajin
Copy link
Member

imbajin commented Feb 13, 2023

@imbajin issue 2 is related to zsh, we can fixed by cd $(echo ./*toolchain*-1.0.0):

zsh $ echo ./*toolchain*
./apache-hugegraph-toolchain-incubating-1.0.0 ./apache-hugegraph-toolchain-incubating-1.0.0.tar.gz

zsh $ echo ./*toolchain*-1.0.0
./apache-hugegraph-toolchain-incubating-1.0.0

zsh $ cd ./*toolchain*          
cd: string not in pwd: ./apache-hugegraph-toolchain-incubating-1.0.0

zsh $ cd $(echo ./*toolchain*-1.0.0)
apache-hugegraph-toolchain-incubating-1.0.0

validate-release.sh in server is outdated and won't be maintained in future, the lastest action contains the suffix already
https://github.com/apache/incubator-hugegraph-doc/blob/cd5952554bd2a14a0910d916e65b21b28b89de4a/.github/workflows/validate-release.yml#L149

The problem 5 also can't be reproduced, maybe it depends on the network status or lack the yarn env?

@javeme
Copy link
Contributor Author

javeme commented Feb 13, 2023

I guess the lack of yarn, can we check and install it automatically?

@imbajin
Copy link
Member

imbajin commented Feb 13, 2023

I guess the lack of yarn, can we check and install it automatically?

Indeed, it should be checked in the pom.xml's config (before generate dist.sh) in toolchain-repo, and also include check wget command, because users will build from the source there but not in the release-check script/action.

@javeme
Copy link
Contributor Author

javeme commented Feb 25, 2024

seems have not addressed all the issues:
https://github.com/apache/incubator-hugegraph-doc/blob/release-1.2.0/dist/validate-release.sh

@liuxiaocs7
Copy link
Member

liuxiaocs7 commented Feb 26, 2024

I guess the lack of yarn, can we check and install it automatically?

yarn will be automatically installed after the frontend-maven-plugin is introduced by (release in 1.3 maybe)

  1. fix(hubble): build with node and yarn incubator-hugegraph-toolchain#543
  2. fix: build error with npm not exist & tiny improve incubator-hugegraph-toolchain#558
  3. refactor(hubble): enhance maven front plugin incubator-hugegraph-toolchain#568

And any questions not addressed for now?

cc: @javeme and @imbajin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shell Issues about shell script
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants