-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): support user defined OKHTTPClient configs #590
Conversation
# Conflicts: # hugegraph-dist/release-docs/LICENSE # hugegraph-dist/release-docs/NOTICE
d5b8031
to
aaf70c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
============================================
- Coverage 62.49% 62.07% -0.43%
+ Complexity 1903 930 -973
============================================
Files 262 93 -169
Lines 9541 4538 -5003
Branches 886 529 -357
============================================
- Hits 5963 2817 -3146
+ Misses 3190 1512 -1678
+ Partials 388 209 -179 ☔ View full report in Codecov by Sentry. |
@@ -99,7 +99,7 @@ | |||
|
|||
<properties> | |||
<revision>1.2.0</revision> | |||
<hugegraph.common.version>1.2.0</hugegraph.common.version> | |||
<hugegraph.common.version>1.3.0</hugegraph.common.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JackyYangPassion we need update the revision
in root before release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Follow apache/incubator-hugegraph-commons#140, add a callback builder for user defined configs in (OK)HTTPClient
Before:
(Users)We have no way to modify the
(HugeClient(RestClient(HttPClient)))
configs, we have to modifyhugegraph-common
which is really inflexible & hard to use...After: