Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): support user defined OKHTTPClient configs #590

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

zhenyuT
Copy link
Contributor

@zhenyuT zhenyuT commented Mar 13, 2024

Follow apache/incubator-hugegraph-commons#140, add a callback builder for user defined configs in (OK)HTTPClient

Before:
(Users)We have no way to modify the (HugeClient(RestClient(HttPClient))) configs, we have to modify hugegraph-common which is really inflexible & hard to use...

After:

            HugeClient.builder(url, graph)
                               .configUser(username, password)
                               .configTimeout(timeout)
                               .configHttpBuilder(x -> x.changeHTTPClientConfigs(....))
                               .build();

# Conflicts:
#	hugegraph-dist/release-docs/LICENSE
#	hugegraph-dist/release-docs/NOTICE
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. client hugegraph-client enhancement New feature or request java Pull requests that update Java code labels Mar 13, 2024
@github-actions github-actions bot added the hubble hugegraph-hubble label Mar 14, 2024
@imbajin imbajin changed the title HugeClient add params feat(client): support user defined OKHTTPClient configs in callback Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.07%. Comparing base (b066b80) to head (aaf70c9).
Report is 25 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #590      +/-   ##
============================================
- Coverage     62.49%   62.07%   -0.43%     
+ Complexity     1903      930     -973     
============================================
  Files           262       93     -169     
  Lines          9541     4538    -5003     
  Branches        886      529     -357     
============================================
- Hits           5963     2817    -3146     
+ Misses         3190     1512    -1678     
+ Partials        388      209     -179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -99,7 +99,7 @@

<properties>
<revision>1.2.0</revision>
<hugegraph.common.version>1.2.0</hugegraph.common.version>
<hugegraph.common.version>1.3.0</hugegraph.common.version>
Copy link
Member

@imbajin imbajin Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackyYangPassion we need update the revision in root before release

Copy link
Member

@liuxiaocs7 liuxiaocs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 15, 2024
@imbajin imbajin changed the title feat(client): support user defined OKHTTPClient configs in callback feat(client): support user defined OKHTTPClient configs Mar 15, 2024
@imbajin imbajin merged commit 7aa9cf1 into apache:master Mar 15, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client hugegraph-client enhancement New feature or request hubble hugegraph-hubble java Pull requests that update Java code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants