Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add stage profile settings #536

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Conversation

zhenyuT
Copy link
Contributor

@zhenyuT zhenyuT commented Nov 22, 2023

Purpose of the PR

  • When commons dependency update, we need to temporarily use the stage repository

subtask of apache/incubator-hugegraph-commons#133

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8fcdd3) 62.47% compared to head (04d2890) 62.49%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #536      +/-   ##
============================================
+ Coverage     62.47%   62.49%   +0.02%     
- Complexity      930     1903     +973     
============================================
  Files            93      262     +169     
  Lines          4509     9541    +5032     
  Branches        529      886     +357     
============================================
+ Hits           2817     5963    +3146     
- Misses         1483     3190    +1707     
- Partials        209      388     +179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imbajin
imbajin previously approved these changes Nov 23, 2023
Comment on lines -43 to -52
- uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'adopt'

- name: Use Node.js 16
uses: actions/setup-node@v3
with:
node-version: '16'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we don't need set java/node env here, the github ubuntu action already have the maven env inside, so remove it now

@simon824 simon824 merged commit e8fd3e0 into apache:master Nov 23, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants