Fix flaky tests in IndexLabelTest due to non deterministic JSON key ordering #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
IndexLabelTest has the following tests that are flaky, detected using the NonDex tool:
org.apache.hugegraph.unit.IndexLabelTest#testIndexLabel
org.apache.hugegraph.unit.IndexLabelTest#testIndexLabelV49
org.apache.hugegraph.unit.IndexLabelTest#testIndexLabelV56
The tests fail due to non-deterministic ordering of the properties in the JSON string created by the
JsonUtil.toJson()
method.Command to reproduce
mvn -pl hugegraph-client edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.hugegraph.unit.IndexLabelTest
Log
Changes
Using the jackson ObjectMapper, comparing the JSONNodes instead of raw json strings would make the test deterministic, as the order of the properties will not be compared.