fix(dist): bin package lack execute permission #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
============================================
+ Coverage 62.55% 62.58% +0.03%
+ Complexity 1866 894 -972
============================================
Files 260 91 -169
Lines 9405 4383 -5022
Branches 872 515 -357
============================================
- Hits 5883 2743 -3140
+ Misses 3140 1437 -1703
+ Partials 382 203 -179 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
coderzc
reviewed
Dec 8, 2022
coderzc
reviewed
Dec 8, 2022
imbajin
changed the title
coderzc
approved these changes
Dec 9, 2022
imbajin
reviewed
Dec 9, 2022
Comment on lines
-190
to
-194
| <directory>output</directory> | ||
| <sourceDirectory>src/main/java</sourceDirectory> | ||
| <!--<testSourceDirectory>src/test/java</testSourceDirectory>--> | ||
| <outputDirectory>output/classes</outputDirectory> | ||
| <!--<testOutputDirectory>output/test-classes</testOutputDirectory>--> |
There was a problem hiding this comment.
@javeme ensure is it useless now?
imbajin
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.