fix(dist): unify binary name for hubble #392
Conversation
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
=========================================
Coverage 62.55% 62.55%
Complexity 1866 1866
=========================================
Files 260 260
Lines 9405 9405
Branches 872 872
=========================================
Hits 5883 5883
Misses 3140 3140
Partials 382 382 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hugegraph-dist/pom.xml
Outdated
| mv $root_path/hugegraph-hubble/hugegraph-hubble ${final.name}/hugegraph-hubble-${project.version} | ||
| mv $root_path/hugegraph-loader/hugegraph-loader-${project.version} ${final.name}/hugegraph-loader-${project.version} | ||
| mv $root_path/hugegraph-tools/hugegraph-tools-${project.version} ${final.name}/hugegraph-tools-${project.version} | ||
| mv $root_path/hugegraph-loader/apache-hugegraph-loader-incubating-${project.version} ${final.name}/apache-hugegraph-loader-incubating-${project.version} | ||
| mv $root_path/hugegraph-tools/apache-hugegraph-tools-incubating-${project.version} ${final.name}/apache-hugegraph-tools-incubating-${project.version} |
There was a problem hiding this comment.
@z7658329 hubble should also rename to apache, and remember check the string path in IDEA (search usage) to avoid inconsistency
and 2 improvement:
- use
mv -vto show the verbose info - condiser use
$root_path/apache-hugegraph-*-incubating*/? (need test it first)
There was a problem hiding this comment.
i have communicate with @JackyYangPassion
1.hubble rename to apache
2.use mv $root_path/apache-hugegraph--incubating/ instead
|
ci error: cp "${TRAVIS_DIR}"/jacocoagent.jar $HUBBLE_DIR/lib || exit 1
cp: cannot create regular file 'hugegraph-hubble/lib': No such file or directory
Error: Process completed with exit code 1. |
| mv -v $root_path/hugegraph-hubble/apache-hugegraph-hubble-incubating-${project.version} ${final.name}/ | ||
| mv -v $root_path/hugegraph-loader/apache-hugegraph-loader-incubating-${project.version} ${final.name}/ | ||
| mv -v $root_path/hugegraph-tools/apache-hugegraph-tools-incubating-${project.version} ${final.name}/ |
There was a problem hiding this comment.
@z7658329 will the ${final.name} be different in one pom file? seems a little strange
is the output right?
There was a problem hiding this comment.
@z7658329 will the
${final.name}be different in one pom file? seems a little strangeis the output right?
make a mistake, the 2nd param is the dest dir (treat as the source dir before, which is wrong)
and shall we use mv -v xx/*/*hugegraph-*xx/ destDir/ to replace current command?
but current way is more accurate, use it
|
i have test in local, seems ok:
|
| @@ -18,7 +18,7 @@ | |||
| set -ev | |||
|
|
|||
| TRAVIS_DIR=$(dirname "$0") | |||
| HUBBLE_DIR="hugegraph-hubble" | |||
| HUBBLE_DIR="apache-hugegraph-hubble-incubating-1.0.0" | |||
There was a problem hiding this comment.
@z7658329 the version should be a variable like $rivison? (not fixed?)
imbajin
changed the title
|
seems fine: TODO: find another error by accident.... (solve it in another PR later)
|
this error always exist, see #338 |
fix #393