-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact(loader): clean code & import style & fix CI bugs #375
Conversation
Note: ensure the hubble building right because it used loader's method
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
============================================
+ Coverage 57.46% 57.51% +0.05%
Complexity 1866 1866
============================================
Files 263 263
Lines 10244 10228 -16
Branches 875 875
============================================
- Hits 5887 5883 -4
+ Misses 3975 3963 -12
Partials 382 382
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ci error: Error: Tests run: 102, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 57.206 s <<< FAILURE! - in org.apache.hugegraph.loader.test.functional.HDFSLoadTest
Error: testParserV2(org.apache.hugegraph.loader.test.functional.HDFSLoadTest) Time elapsed: 0.612 s <<< ERROR!
com.beust.jcommander.ParameterException: Ensure the file exists and is indeed a file instead of a directory: 'target/test-classes/mapping_v2/struct_hdfs.json'
[INFO]
[INFO] Results:
[INFO]
Error: Errors:
Error: HDFSLoadTest>FileLoadTest.testParserV2:1871 » Parameter Ensure the file exists...
[INFO]
Error: Tests run: 102, Failures: 0, Errors: 1, Skipped: 0 |
if (this.context.options().testMode) { | ||
throw e; | ||
} | ||
throw e; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't throw exception if non-testMode, because the user experience is not good if print the stack trace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for testing the bug in HDFS now (it's hard to test in local env...)
Note: ensure the hubble building right because it used loader's method