refact(loader): clean code & import style & fix CI bugs #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: ensure the hubble building right because it used loader's method
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
============================================
+ Coverage 57.46% 57.51% +0.05%
Complexity 1866 1866
============================================
Files 263 263
Lines 10244 10228 -16
Branches 875 875
============================================
- Hits 5887 5883 -4
+ Misses 3975 3963 -12
Partials 382 382
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
need fix... |
javeme
previously approved these changes
Nov 21, 2022
|
ci error: Error: Tests run: 102, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 57.206 s <<< FAILURE! - in org.apache.hugegraph.loader.test.functional.HDFSLoadTest
Error: testParserV2(org.apache.hugegraph.loader.test.functional.HDFSLoadTest) Time elapsed: 0.612 s <<< ERROR!
com.beust.jcommander.ParameterException: Ensure the file exists and is indeed a file instead of a directory: 'target/test-classes/mapping_v2/struct_hdfs.json'
[INFO]
[INFO] Results:
[INFO]
Error: Errors:
Error: HDFSLoadTest>FileLoadTest.testParserV2:1871 » Parameter Ensure the file exists...
[INFO]
Error: Tests run: 102, Failures: 0, Errors: 1, Skipped: 0 |
imbajin
changed the title
javeme
reviewed
Nov 24, 2022
| if (this.context.options().testMode) { | ||
| throw e; | ||
| } | ||
| throw e; |
There was a problem hiding this comment.
can't throw exception if non-testMode, because the user experience is not good if print the stack trace.
There was a problem hiding this comment.
just for testing the bug in HDFS now (it's hard to test in local env...)
coderzc
approved these changes
Nov 25, 2022
javeme
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: ensure the hubble building right because it used loader's method