-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact(client): adapt import & style with latest code #369
Conversation
check all class manually
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
============================================
- Coverage 57.52% 57.40% -0.12%
Complexity 1864 1864
============================================
Files 263 263
Lines 10272 10244 -28
Branches 877 875 -2
============================================
- Hits 5909 5881 -28
Misses 3979 3979
Partials 384 384
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hugegraph-client/src/main/java/org/apache/hugegraph/structure/graph/Edge.java
Outdated
Show resolved
Hide resolved
EdgeLabelApiTest.class, | ||
IndexLabelApiTest.class, | ||
SchemaApiTest.class, | ||
PropertyKeyApiTest.class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javeme how many spaces shall we keep in @Annotation({p1, p2, p3})
? Is 4 spaces right?
and we could unify the annotation style
hugegraph-client/src/test/java/org/apache/hugegraph/api/EdgeApiTest.java
Outdated
Show resolved
Hide resolved
hugegraph-client/src/test/java/org/apache/hugegraph/api/TaskApiTest.java
Show resolved
Hide resolved
hugegraph-client/src/test/java/org/apache/hugegraph/api/TaskApiTest.java
Outdated
Show resolved
Hide resolved
MetricsManagerTest.class, | ||
HugeClientHttpsTest.class, | ||
HugeClientTest.class | ||
PropertyKeyTest.class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as the annotation style problem
CommonUtilTest.class, | ||
IdUtilTest.class, | ||
SplicingIdGeneratorTest.class | ||
VertexSerializerTest.class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -124,14 +124,17 @@ private void writeGraphElements() { | |||
vadasB.property("price", "120"); | |||
vadasB.id(12345); | |||
|
|||
Edge peterCreateLop = new Edge("created").source(peter).target(lop).property("date", "2017-03-24"); | |||
Edge peterCreateLop = new Edge("created").source(peter).target(lop) | |||
.property("date", "2017-03-24"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
align with .source
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check all class in
client
module manuallyand the basic rule is we should avoid using a special align style, it's not friendly for normal users to format the code (Greatly reduces the efficiency of commit)
use the config file to format the file automatically is more sensible, and we could reduce to review the
space/align/empty line/wrong import
also.