chore: update spark&flink scope to provided #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
=========================================
Coverage 62.44% 62.44%
Complexity 1864 1864
=========================================
Files 260 260
Lines 9462 9462
Branches 874 874
=========================================
Hits 5909 5909
Misses 3169 3169
Partials 384 384 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
previously approved these changes
Nov 10, 2022
|
find another problem when test release, currently the package file is too big (seems we should config maven-assembly-plugin or
refer: incubator-hugegraph-toolchain/pom.xml Line 220 in c893f50 maybe we could package the release in local env first (check and reduce the useless dependencies) |
# Conflicts: # hugegraph-dist/scripts/dependency/known-dependencies.txt
javeme
approved these changes
Nov 10, 2022
imbajin
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spark&flink loader needs to depend on the local spark&flink environment, so it's not necessary to introduce these dependencies in toolchains.