Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apache): support check license header with RAT client model #352

Merged
merged 24 commits into from
Nov 28, 2022

Conversation

JackyYangPassion
Copy link
Contributor

@JackyYangPassion JackyYangPassion commented Oct 31, 2022

support check & fix license header with skywalking-eyes

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header check
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

reference apache/incubator-hugegraph#2034

@z7658329
Copy link
Member

the same as #338 ?

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #352 (c01f5e1) into master (6163afe) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #352   +/-   ##
=========================================
  Coverage     62.55%   62.55%           
  Complexity     1866     1866           
=========================================
  Files           260      260           
  Lines          9405     9405           
  Branches        872      872           
=========================================
  Hits           5883     5883           
  Misses         3140     3140           
  Partials        382      382           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pom.xml Outdated Show resolved Hide resolved
javeme
javeme previously approved these changes Nov 2, 2022
javeme
javeme previously approved these changes Nov 7, 2022
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we use the original rat-step in each module? Or just clean them

and now the RAT-CI will enable & stop each ci, consider enhance it? (leave a separate one)

image

javeme
javeme previously approved these changes Nov 8, 2022
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refer apache/incubator-hugegraph#2009

and use a unified way in all repos

@JackyYangPassion
Copy link
Contributor Author

refer apache/incubator-hugegraph#2009

and use a unified way in all repos

ok

.github/workflows/license-checker.yml Outdated Show resolved Hide resolved
.licenserc.yaml Outdated Show resolved Hide resolved
@imbajin imbajin added dependencies Pull requests that update a dependency file ci Continuous integration apache labels Nov 9, 2022
javeme
javeme previously approved these changes Nov 9, 2022
@imbajin
Copy link
Member

imbajin commented Nov 10, 2022

the same question in server, how could it add the license automatically? currently, it throws problems only

image

.licenserc.yaml Outdated Show resolved Hide resolved
@JackyYangPassion
Copy link
Contributor Author

the same question in server, how could it add the license automatically? currently, it throws problems only

image

It was verified last night that it didn't work. I'll solve it later

@javeme
Copy link
Contributor

javeme commented Nov 22, 2022

license check error:

INFO Totally checked 1547 files, valid: 710, invalid: 251, ignored: 586, fixed: 0 
ERROR the following files don't have a valid license header: 
hugegraph-dist/pom.xml
hugegraph-hubble/.prettierrc
hugegraph-hubble/.stylelintrc
hugegraph-hubble/hubble-be/pom.xml
hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/entity/schema/SchemaConflict.java
hugegraph-hubble/hubble-be/src/main/resources/database/data.sql
hugegraph-hubble/hubble-be/src/main/resources/database/schema.sql

dependency check error:

Error:  Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (docker-build) on project hubble-dist: 
 Execution docker-build of goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec failed:
  Plugin org.codehaus.mojo:exec-maven-plugin:3.0.0 or one of its dependencies could not be resolved:
   Failed to collect dependencies at org.codehaus.mojo:exec-maven-plugin:jar:3.0.0 -> org.apache.commons:commons-exec:jar:1.3:
    Failed to read artifact descriptor for org.apache.commons:commons-exec:jar:1.3:
     Could not transfer artifact org.apache.commons:commons-exec:pom:1.3 from/to central (https://repo.maven.apache.org/maven2):
      transfer failed for https://repo.maven.apache.org/maven2/org/apache/commons/commons-exec/1.3/commons-exec-1.3.pom:
       Connection timed out (Read failed) -> [Help 1]

@JackyYangPassion
Copy link
Contributor Author

the same question in server, how could it add the license automatically? currently, it throws problems only
image

It was verified last night that it didn't work. I'll solve it later

add license automatically with cmd:

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

@javeme javeme merged commit 0a72868 into apache:master Nov 28, 2022
imbajin pushed a commit to imbaGeek/hugegraph-toolchain that referenced this pull request Jan 19, 2023
* i18n for basic ui comment
* i18n for built-in text, such as confirmation, cancellation, etc
* fix style:  1) the menu is not centered  2) style of vertex/edge manipulation
* add additional json configuration and the replacement example
@imbajin
Copy link
Member

imbajin commented Feb 14, 2023

invalid file:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apache ci Continuous integration dependencies Pull requests that update a dependency file
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants