Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the missing mail address #345

Merged
merged 2 commits into from
Nov 7, 2022
Merged

chore: fix the missing mail address #345

merged 2 commits into from
Nov 7, 2022

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Oct 26, 2022

This PR should merge as soon as possible (to avoid sending error mail by apache)

@imbajin imbajin self-assigned this Oct 26, 2022
@imbajin imbajin requested a review from javeme October 26, 2022 15:32
@imbajin imbajin requested a review from zyxxoo November 1, 2022 16:53
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #345 (ce4d450) into master (6d82b15) will decrease coverage by 28.52%.
The diff coverage is 71.42%.

@@              Coverage Diff              @@
##             master     #345       +/-   ##
=============================================
- Coverage     67.43%   38.91%   -28.53%     
- Complexity      878      966       +88     
=============================================
  Files            86      242      +156     
  Lines          4029     8113     +4084     
  Branches        477      720      +243     
=============================================
+ Hits           2717     3157      +440     
- Misses         1107     4777     +3670     
+ Partials        205      179       -26     
Impacted Files Coverage Δ
...java/com/baidu/hugegraph/structure/constant/T.java 0.00% <ø> (ø)
...java/com/baidu/hugegraph/structure/graph/Path.java 73.52% <0.00%> (ø)
...com/baidu/hugegraph/exception/ServerException.java 69.04% <50.00%> (ø)
.../java/com/baidu/hugegraph/driver/GraphManager.java 87.17% <100.00%> (ø)
.../com/baidu/hugegraph/loader/source/SourceType.java 0.00% <0.00%> (-100.00%) ⬇️
...m/baidu/hugegraph/loader/parser/CsvLineParser.java 0.00% <0.00%> (-100.00%) ⬇️
.../baidu/hugegraph/loader/reader/AbstractReader.java 0.00% <0.00%> (-100.00%) ⬇️
...baidu/hugegraph/loader/source/file/FileFormat.java 0.00% <0.00%> (-100.00%) ⬇️
...aidu/hugegraph/loader/executor/GroovyExecutor.java 0.00% <0.00%> (-100.00%) ⬇️
...aidu/hugegraph/loader/source/file/Compression.java 0.00% <0.00%> (-100.00%) ⬇️
... and 227 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin
Copy link
Member Author

imbajin commented Nov 3, 2022

@javeme @coderzc merge this PR to avoid sending error alert to private mail group

# Note: before use the config, we need ensure the "mail" address has set well (exist)
#pullrequests_comment: issues@hugegraph.apache.org
#issues: issues@hugegraph.apache.org
#discussions: issues@hugegraph.apache.org
Copy link
Contributor

@javeme javeme Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 spaces in : issues

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it in another PR --- @z7658329 could address it together

@coderzc coderzc merged commit df09107 into master Nov 7, 2022
@coderzc coderzc deleted the fix-mail branch November 7, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants