refact: show detail info when parse line meet error #325
Conversation
| "The length of names %s should be same as values %s", | ||
| Arrays.toString(names), | ||
| Arrays.toString(values)); |
There was a problem hiding this comment.
please keep the original align style, thanks
and better to show/paste the difference in comment
imbajin
changed the title
imbajin
changed the title
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
============================================
- Coverage 67.49% 0.00% -67.50%
============================================
Files 86 86
Lines 4024 4031 +7
Branches 475 478 +3
============================================
- Hits 2716 0 -2716
- Misses 1104 4031 +2927
+ Partials 204 0 -204
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Any update with this pr? Just some tiny comments |
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
There was a problem hiding this comment.
@BestBurning Thanks for your contribution, could you please address the comments, and we will merge this PR as soon as you make the changes.
| @@ -37,7 +38,9 @@ public Line(String rawLine, String[] names, Object[] values) { | |||
| E.checkArgumentNotNull(names, "The names can't be null"); | |||
| E.checkArgumentNotNull(values, "The values can't be null"); | |||
| E.checkArgument(names.length == values.length, | |||
| "The length of names %s should be same as values %s"); | |||
| "The length of names %s should be same as values %s", | |||
| Arrays.toString(names), | |||
There was a problem hiding this comment.
prefer to add if-statement check to avoid unnecessary toString() call:
if (names.length != values.length) {
E.checkArgument(...);
}
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
fix line cheack argument, then it'll show detail info